From: Jan Blunck <jblunck@infradead.org>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: dev <dev@dpdk.org>,
"cjcollier @ linuxfoundation . org"
<cjcollier@linuxfoundation.org>,
ricardo.salveti@linaro.org,
Luca Boccassi <luca.boccassi@gmail.com>
Subject: Re: [dpdk-dev] [PATCH] mk: Provide option to set Major ABI version
Date: Tue, 28 Feb 2017 09:34:27 +0100 [thread overview]
Message-ID: <CALe+Z00fkiaQ5uspGZ1kE9gnOvDPLZ5h=vgDswL3nM85pEPGQA@mail.gmail.com> (raw)
In-Reply-To: <1487769892-17042-1-git-send-email-christian.ehrhardt@canonical.com>
On Wed, Feb 22, 2017 at 2:24 PM, Christian Ehrhardt
<christian.ehrhardt@canonical.com> wrote:
> --- a/mk/rte.lib.mk
> +++ b/mk/rte.lib.mk
> @@ -40,6 +40,12 @@ EXTLIB_BUILD ?= n
> # VPATH contains at least SRCDIR
> VPATH += $(SRCDIR)
>
> +ifneq ($(CONFIG_RTE_MAJOR_ABI),)
> +ifneq ($(LIBABIVER),)
> +LIBABIVER := $(CONFIG_RTE_MAJOR_ABI)
> +endif
> +endif
> +
> ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
> LIB := $(patsubst %.a,%.so.$(LIBABIVER),$(LIB))
> ifeq ($(EXTLIB_BUILD),n)
> @@ -156,11 +162,7 @@ $(RTE_OUTPUT)/lib/$(LIB): $(LIB)
> @[ -d $(RTE_OUTPUT)/lib ] || mkdir -p $(RTE_OUTPUT)/lib
> $(Q)cp -f $(LIB) $(RTE_OUTPUT)/lib
> ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
> -ifeq ($(CONFIG_RTE_NEXT_ABI)$(EXTLIB_BUILD),yn)
> - $(Q)ln -s -f $< $(basename $(basename $@))
> -else
> - $(Q)ln -s -f $< $(basename $@)
> -endif
> + $(Q)ln -s -f $< $(shell echo $@ | sed 's/\.so.*/.so/')
> endif
>
In case CONFIG_RTE_NEXT_ABI=y is set this is actually generating
shared objects with suffix:
.so.$(CONFIG_RTE_MAJOR_ABI).1
I don't think that this is the intention.
next prev parent reply other threads:[~2017-02-28 8:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 10:52 [dpdk-dev] Further fun with ABI tracking Christian Ehrhardt
2017-02-14 16:19 ` Bruce Richardson
2017-02-14 20:31 ` Jan Blunck
2017-02-22 13:12 ` Christian Ehrhardt
2017-02-22 13:24 ` [dpdk-dev] [PATCH] mk: Provide option to set Major ABI version Christian Ehrhardt
2017-02-28 8:34 ` Jan Blunck [this message]
2017-03-01 9:31 ` Christian Ehrhardt
2017-03-01 9:34 ` [dpdk-dev] [PATCH v2] " Christian Ehrhardt
2017-03-01 14:35 ` Jan Blunck
2017-03-16 17:19 ` Thomas Monjalon
2017-03-17 8:27 ` Christian Ehrhardt
2017-03-17 9:16 ` Jan Blunck
2017-02-23 18:48 ` [dpdk-dev] Further fun with ABI tracking Ferruh Yigit
2017-02-24 7:32 ` Christian Ehrhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALe+Z00fkiaQ5uspGZ1kE9gnOvDPLZ5h=vgDswL3nM85pEPGQA@mail.gmail.com' \
--to=jblunck@infradead.org \
--cc=christian.ehrhardt@canonical.com \
--cc=cjcollier@linuxfoundation.org \
--cc=dev@dpdk.org \
--cc=luca.boccassi@gmail.com \
--cc=ricardo.salveti@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).