From: Jan Blunck <jblunck@infradead.org>
To: David Marchand <david.marchand@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [dpdk-dev] [PATCH 4/7] virtio: Don't fill dev_info->driver_name
Date: Mon, 21 Nov 2016 17:34:44 +0100 [thread overview]
Message-ID: <CALe+Z015KyNZKrasimQCuM6V6ggfSgDJJO4y00K-Zx32kUT0EQ@mail.gmail.com> (raw)
In-Reply-To: <CALwxeUt0d+s9hBCX-TcL-Fms-v7ozqEg7zOYy6NsJsV5rUHRGA@mail.gmail.com>
On Sun, Nov 20, 2016 at 4:22 PM, David Marchand
<david.marchand@6wind.com> wrote:
> On Sun, Nov 20, 2016 at 11:05 AM, Jan Blunck <jblunck@infradead.org> wrote:
>> This is overwritten in rte_eth_dev_info_get().
>>
>> Signed-off-by: Jan Blunck <jblunck@infradead.org>
>> ---
>> drivers/net/virtio/virtio_ethdev.c | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
>> index 079fd6c..741688e 100644
>> --- a/drivers/net/virtio/virtio_ethdev.c
>> +++ b/drivers/net/virtio/virtio_ethdev.c
>> @@ -1624,10 +1624,6 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
>> uint64_t tso_mask;
>> struct virtio_hw *hw = dev->data->dev_private;
>>
>> - if (dev->pci_dev)
>> - dev_info->driver_name = dev->driver->pci_drv.driver.name;
>> - else
>> - dev_info->driver_name = "virtio_user PMD";
>> dev_info->max_rx_queues =
>> RTE_MIN(hw->max_queue_pairs, VIRTIO_MAX_RX_QUEUES);
>> dev_info->max_tx_queues =
>> --
>> 2.7.4
>>
>
> I posted something similar [1], so looks good to me :-)
>
> [1]: http://dpdk.org/dev/patchwork/patch/16991/
>
Thanks for reviewing. Do we go with your proposal then? Do you plan to
follow up on the comments?
next prev parent reply other threads:[~2016-11-21 16:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-20 10:05 [dpdk-dev] [PATCH 1/7] eal: define container_of macro Jan Blunck
2016-11-20 10:05 ` [dpdk-dev] [PATCH 2/7] eal: Helper to convert to struct rte_pci_device Jan Blunck
2016-11-20 15:20 ` David Marchand
2016-11-21 16:57 ` Jan Blunck
2016-11-20 10:05 ` [dpdk-dev] [PATCH 3/7] drivers: Use ETH_DEV_PCI_DEV() helper Jan Blunck
2016-11-20 10:05 ` [dpdk-dev] [PATCH 4/7] virtio: Don't fill dev_info->driver_name Jan Blunck
2016-11-20 15:22 ` David Marchand
2016-11-21 16:34 ` Jan Blunck [this message]
2016-11-21 16:49 ` David Marchand
2016-11-21 16:52 ` Jan Blunck
2016-11-20 10:05 ` [dpdk-dev] [PATCH 5/7] virtio: Add vtpci_intr_handle() helper to get rte_intr_handle Jan Blunck
2016-11-20 10:05 ` [dpdk-dev] [PATCH 6/7] virtio: Don't depend on struct rte_eth_dev's pci_dev Jan Blunck
2016-11-20 10:05 ` [dpdk-dev] [PATCH 7/7] ethdev: Move filling of rte_eth_dev_info->pci_dev to dev_infos_get() Jan Blunck
2016-11-20 15:23 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALe+Z015KyNZKrasimQCuM6V6ggfSgDJJO4y00K-Zx32kUT0EQ@mail.gmail.com \
--to=jblunck@infradead.org \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=shreyansh.jain@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).