From: Jan Blunck <jblunck@infradead.org>
To: Declan Doherty <declan.doherty@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Eric Kinzie <ehkinzie@gmail.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] bond: avoid allocating mempool on socket LCORE_ID_ANY
Date: Wed, 28 Jun 2017 14:00:14 +0200 [thread overview]
Message-ID: <CALe+Z01DGVCYrdGFib_raFX7iSUK0SA_Ve9sg7ZCQVc8bJSnmw@mail.gmail.com> (raw)
In-Reply-To: <44751a6e-4a2c-a53e-3fdc-89a95be3f5f3@intel.com>
On Wed, Jun 28, 2017 at 11:47 AM, Declan Doherty
<declan.doherty@intel.com> wrote:
> On 26/04/17 22:30, Jan Blunck wrote:
>>
>> If the numa node is unknown, use the value from rte_socket_id() to avoid
>> an allocation failure.
>>
>> Signed-off-by: Eric Kinzie <ekinzie@brocade.com>
>> CC: Eric Kinzie <ehkinzie@gmail.com>
>> ---
>> drivers/net/bonding/rte_eth_bond_8023ad.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c
>> b/drivers/net/bonding/rte_eth_bond_8023ad.c
>> index 7b863d6..b8df536 100644
>> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
>> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
>> @@ -887,6 +887,8 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev
>> *bond_dev, uint8_t slave_id)
>> RTE_ASSERT(port->rx_ring == NULL);
>> RTE_ASSERT(port->tx_ring == NULL);
>> socket_id = rte_eth_devices[slave_id].data->numa_node;
>> + if (socket_id == (uint8_t)LCORE_ID_ANY)
>
>
> socket_id is an integer so we shouldn't be casting LCORE_ID_ANY to an
> uint8_t as this condition would never match as LCORE_ID_ANY wouldn't be
> UINT32_MAX after casting
>
Ouch ... let me fix this.
>> + socket_id = 0;
>
>
> Should this not be socket_id = rte_socket_id(); as we don't know we are
> running on
>
>
>> element_size = sizeof(struct slow_protocol_frame) +
>> RTE_PKTMBUF_HEADROOM;
>>
>
next prev parent reply other threads:[~2017-06-28 12:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 21:30 Jan Blunck
2017-04-26 21:30 ` [dpdk-dev] [PATCH 2/2] bond: use rte_eth_dev_socket_id() Jan Blunck
2017-06-28 9:49 ` Declan Doherty
2017-06-28 9:47 ` [dpdk-dev] [PATCH 1/2] bond: avoid allocating mempool on socket LCORE_ID_ANY Declan Doherty
2017-06-28 12:00 ` Jan Blunck [this message]
2017-06-30 14:34 ` [dpdk-dev] [PATCH v2 " Declan Doherty
2017-06-30 14:34 ` [dpdk-dev] [PATCH v2 2/2] bond: use rte_eth_dev_socket_id() Declan Doherty
2017-07-03 12:17 ` [dpdk-dev] [PATCH v2 1/2] bond: avoid allocating mempool on socket LCORE_ID_ANY Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALe+Z01DGVCYrdGFib_raFX7iSUK0SA_Ve9sg7ZCQVc8bJSnmw@mail.gmail.com \
--to=jblunck@infradead.org \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ehkinzie@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).