From: Jan Blunck <jblunck@infradead.org>
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Cc: dev <dev@dpdk.org>, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v5 1/7] bus: fix bus name registration
Date: Tue, 27 Jun 2017 21:19:14 +0200 [thread overview]
Message-ID: <CALe+Z01GL_MDMyoEvwe=bFpac_KS0uCMDs56VyREhcWESwfK2A@mail.gmail.com> (raw)
In-Reply-To: <206669e001a4561a5f5c10deebcf70742688f380.1497999826.git.gaetan.rivet@6wind.com>
On Wed, Jun 21, 2017 at 1:30 AM, Gaetan Rivet <gaetan.rivet@6wind.com> wrote:
> The default bus registration function should not result in buses
> registering with double quotes within their names.
>
This is breaking expectations with users. All other registration macro
pass the names through the stringification. The problem is that you
pass in the name as a string already ("PCI" instead of PCI).
> Fixes: a97725791eec ("bus: introduce bus abstraction")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
> lib/librte_eal/common/include/rte_bus.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h
> index fcc2442..b220299 100644
> --- a/lib/librte_eal/common/include/rte_bus.h
> +++ b/lib/librte_eal/common/include/rte_bus.h
> @@ -254,7 +254,7 @@ struct rte_bus *rte_bus_find_by_device(const struct rte_device *dev);
> #define RTE_REGISTER_BUS(nm, bus) \
> static void __attribute__((constructor(101), used)) businitfn_ ##nm(void) \
> {\
> - (bus).name = RTE_STR(nm);\
> + (bus).name = nm;\
> rte_bus_register(&bus); \
> }
>
> --
> 2.1.4
>
next prev parent reply other threads:[~2017-06-27 19:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1495629122.git.gaetan.rivet@6wind.com>
2017-05-24 15:12 ` [dpdk-stable] [PATCH 1/9] " Gaetan Rivet
[not found] ` <cover.1495642202.git.gaetan.rivet@6wind.com>
2017-05-24 16:15 ` [dpdk-stable] [PATCH v2 " Gaetan Rivet
[not found] ` <cover.1496311609.git.gaetan.rivet@6wind.com>
2017-06-01 10:08 ` [dpdk-stable] [PATCH v3 " Gaetan Rivet
[not found] ` <cover.1496876810.git.gaetan.rivet@6wind.com>
2017-06-07 23:56 ` [dpdk-stable] [PATCH v4 " Gaetan Rivet
[not found] ` <cover.1497999826.git.gaetan.rivet@6wind.com>
2017-06-20 23:30 ` [dpdk-stable] [PATCH v5 1/7] " Gaetan Rivet
2017-06-27 15:53 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2017-06-27 19:19 ` Jan Blunck [this message]
2017-07-04 1:05 ` Gaëtan Rivet
[not found] ` <cover.1499127915.git.gaetan.rivet@6wind.com>
2017-07-04 0:58 ` [dpdk-stable] [PATCH v6 1/6] " Gaetan Rivet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALe+Z01GL_MDMyoEvwe=bFpac_KS0uCMDs56VyREhcWESwfK2A@mail.gmail.com' \
--to=jblunck@infradead.org \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).