From: Jan Blunck <jblunck@infradead.org>
To: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
Cc: dev <dev@dpdk.org>, Billy McFall <bmcfall@redhat.com>,
Olivier MATZ <olivier.matz@6wind.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Elad Persiko <eladpe@mellanox.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v2 1/5] ethdev: introduce device removal event
Date: Tue, 2 May 2017 09:35:38 +0200 [thread overview]
Message-ID: <CALe+Z03HZkGh8a41uyJU5BLhc=bjT5Wh2KD=-Nk1b8RyhNqMvA@mail.gmail.com> (raw)
In-Reply-To: <20170425090536.GS14914@bidouze.vm.6wind.com>
Am 25.04.2017 11:06 schrieb "Gaëtan Rivet" <gaetan.rivet@6wind.com>:
Hi Ferruh,
On Fri, Apr 21, 2017 at 03:59:24PM +0100, Ferruh Yigit wrote:
> On 4/18/2017 1:17 PM, Gaetan Rivet wrote:
>
>> This new API allows reacting to a device removal.
>> A device removal is the sudden disappearance of a device from its
>> bus.
>>
>
I don't think this belongs into ethdev. If it is bus related we need to
expose this from it so that apps can register for the low level device
being unplugged.
Jan
>> PMDs implementing support for this notification guarantee that the removal
>> of the underlying device does not incur a risk to the application.
>>
>> In particular, Rx/Tx bursts and all other functions can still be called
>> (albeit likely returning errors) without triggering a crash, irrespective
>> of an application handling this event.
>>
>> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
>> Signed-off-by: Elad Persiko <eladpe@mellanox.com>
>>
>
> <...>
>
> diff --git a/doc/guides/nics/features/default.ini
>> b/doc/guides/nics/features/default.ini
>> index b1b9114..cafc6c7 100644
>> --- a/doc/guides/nics/features/default.ini
>> +++ b/doc/guides/nics/features/default.ini
>> @@ -10,6 +10,7 @@
>> Speed capabilities =
>> Link status =
>> Link status event =
>> +Removal event =
>> Queue status event =
>> Rx interrupt =
>> Free Tx mbuf on demand =
>>
>
> This release a few NIC features added, and it is hard to follow them if
> you are particularly looking for these features.
>
> So do you think does it make sense to put those new PMD features into
> release notes to make it more visible?
>
>
Yes it seems like a good idea to announce this evolution. I will
send the relevant patch for this soon.
Thanks,
> ferruh
>
--
Gaėtan Rivet
6WIND
next prev parent reply other threads:[~2017-05-02 7:35 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 15:40 [dpdk-dev] [PATCH 0/5] add " Gaetan Rivet
2017-03-03 15:40 ` [dpdk-dev] [PATCH 1/5] ethdev: introduce " Gaetan Rivet
2017-03-03 15:40 ` [dpdk-dev] [PATCH 2/5] net/mlx4: device removal event support Gaetan Rivet
2017-03-03 15:40 ` [dpdk-dev] [PATCH 3/5] app/testpmd: generic event handler Gaetan Rivet
2017-03-03 15:40 ` [dpdk-dev] [PATCH 4/5] app/testpmd: request link status interrupt Gaetan Rivet
2017-03-03 15:40 ` [dpdk-dev] [PATCH 5/5] app/testpmd: request device removal interrupt Gaetan Rivet
2017-03-23 10:24 ` [dpdk-dev] [PATCH 0/5] add device removal event Gaetan Rivet
2017-04-18 12:17 ` [dpdk-dev] [PATCH v2 " Gaetan Rivet
2017-04-18 12:17 ` [dpdk-dev] [PATCH v2 1/5] ethdev: introduce " Gaetan Rivet
2017-04-21 14:59 ` Ferruh Yigit
2017-04-25 9:05 ` Gaëtan Rivet
2017-05-02 7:35 ` Jan Blunck [this message]
2017-05-02 9:18 ` Thomas Monjalon
2017-05-02 12:20 ` Gaëtan Rivet
2017-04-18 12:17 ` [dpdk-dev] [PATCH v2 2/5] net/mlx4: device removal event support Gaetan Rivet
2017-04-18 12:17 ` [dpdk-dev] [PATCH v2 3/5] app/testpmd: generic event handler Gaetan Rivet
2017-04-18 12:17 ` [dpdk-dev] [PATCH v2 4/5] app/testpmd: request link status interrupt Gaetan Rivet
2017-04-21 14:55 ` Ferruh Yigit
2017-04-25 9:07 ` Gaëtan Rivet
2017-04-25 9:40 ` Ferruh Yigit
2017-04-25 10:10 ` [dpdk-dev] [PATCH 1/3] doc: fix missing backquotes Gaetan Rivet
2017-04-25 10:10 ` [dpdk-dev] [PATCH 2/3] doc: add device removal event to release note Gaetan Rivet
2017-04-25 10:10 ` [dpdk-dev] [PATCH 3/3] doc: add lsc and rmv interrupt to testpmd user guide Gaetan Rivet
2017-04-25 10:18 ` [dpdk-dev] [PATCH v2 1/4] doc: fix missing backquotes Gaetan Rivet
2017-04-25 10:18 ` [dpdk-dev] [PATCH v2 2/4] doc: add device removal event to release note Gaetan Rivet
2017-04-26 14:59 ` Mcnamara, John
2017-04-25 10:18 ` [dpdk-dev] [PATCH v2 3/4] doc: add LSC and RMV interrupt to testpmd user guide Gaetan Rivet
2017-04-26 15:00 ` Mcnamara, John
2017-04-25 10:18 ` [dpdk-dev] [PATCH v2 4/4] devtools: add git log checks for rmv Gaetan Rivet
2017-04-26 15:01 ` Mcnamara, John
2017-04-30 22:28 ` Thomas Monjalon
2017-04-26 14:58 ` [dpdk-dev] [PATCH v2 1/4] doc: fix missing backquotes Mcnamara, John
2017-04-30 22:30 ` Thomas Monjalon
2017-04-18 12:17 ` [dpdk-dev] [PATCH v2 5/5] app/testpmd: request device removal interrupt Gaetan Rivet
2017-04-20 22:45 ` [dpdk-dev] [PATCH v2 0/5] add device removal event Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALe+Z03HZkGh8a41uyJU5BLhc=bjT5Wh2KD=-Nk1b8RyhNqMvA@mail.gmail.com' \
--to=jblunck@infradead.org \
--cc=bmcfall@redhat.com \
--cc=dev@dpdk.org \
--cc=eladpe@mellanox.com \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).