From: Jan Blunck <jblunck@infradead.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] eal: internalize devargs parsing
Date: Sun, 9 Jul 2017 06:56:25 -0400 [thread overview]
Message-ID: <CALe+Z03dJ0KDmYS=3VorQg-ORxTVdA9zE_Dp6fC-+NkbT9Ao6Q@mail.gmail.com> (raw)
In-Reply-To: <CALe+Z00j4X6+5Ay9XMqn-_sjy028q_tHues9DC3qFmSU42crmg@mail.gmail.com>
On Sun, Jul 9, 2017 at 6:46 AM, Jan Blunck <jblunck@infradead.org> wrote:
> On Sun, Jul 9, 2017 at 6:28 AM, Thomas Monjalon <thomas@monjalon.net> wrote:
>> 09/07/2017 11:28, Jan Blunck:
>>> This is going to get cleaned up in future releases so lets not expose
>>> this API unnecessarily.
>>>
>>> Signed-off-by: Jan Blunck <jblunck@infradead.org>
>>> ---
>>> --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
>>> +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
>>> @@ -211,7 +211,6 @@ DPDK_17.08 {
>>> EXPERIMENTAL {
>>> global:
>>>
>>> - rte_eal_devargs_parse;
>>> rte_eal_hotplug_add;
>>> rte_eal_hotplug_remove;
>>
>> We need to expose it temporarily as experimental in order to let
>> the failsafe driver calling it.
>> When reworked in 17.11, this function or an equivalent should allow
>> failsafe (and maybe bonding) to parse slave declaration.
>
> There is no need for the failsafe PMD to parse it to a rte_devargs
> because it can just pass the string to the hotplug API.
Just in case it isn't clear enough: the failsafe PMD is using the
rte_devargs structure to get the bus name. The bus name is explicitly
given in the hotplug API. There is really no need to deal with
rte_devargs here.
next prev parent reply other threads:[~2017-07-09 10:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-09 9:28 [dpdk-dev] [PATCH 0/2] devargs changes / deprecation notice Jan Blunck
2017-07-09 9:28 ` [dpdk-dev] [PATCH 1/2] eal: internalize devargs parsing Jan Blunck
2017-07-09 10:28 ` Thomas Monjalon
2017-07-09 10:46 ` Jan Blunck
2017-07-09 10:56 ` Jan Blunck [this message]
2017-07-09 11:23 ` Gaëtan Rivet
2017-07-09 9:28 ` [dpdk-dev] [PATCH 2/2] eal: deprecate 17.08 devargs API/ABI Jan Blunck
2017-07-09 12:25 ` Shreyansh Jain
2017-08-07 23:03 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALe+Z03dJ0KDmYS=3VorQg-ORxTVdA9zE_Dp6fC-+NkbT9Ao6Q@mail.gmail.com' \
--to=jblunck@infradead.org \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).