From: David Marchand <david.marchand@6wind.com>
To: remy.horton@intel.com, "Iremonger,
Bernard" <bernard.iremonger@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Cc: stable@dpdk.org, dev@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] app/testpmd: add sanity checks when retrieving xstats
Date: Tue, 12 Jun 2018 09:09:52 +0200 [thread overview]
Message-ID: <CALwxeUsBYGb+0XEk4o-yb2xJ+4ZkJov5dL_E-_X3XZDwqUxD7Q@mail.gmail.com> (raw)
In-Reply-To: <1528359323-22885-1-git-send-email-david.marchand@6wind.com>
Hey guys,
On Thu, Jun 7, 2018 at 10:15 AM, David Marchand
<david.marchand@6wind.com> wrote:
> Testpmd should not expect the xstats names and values arrays to be
> aligned: neither the arrays sizes, nor the order in which the values are.
>
> This hid some bugs where pmds would either return wrong values count or
> invalid statistics indexes.
>
> Link: http://dpdk.org/browse/dpdk/commit/?id=5fd4d049692b2fde8bf49c7461b18180a8fd2545
> Link: http://dpdk.org/dev/patchwork/patch/40705/
>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
> ---
>
> @stable: when this goes in, I recommend backporting this to all existing
> branches, as it makes it easier to show this kind of pmds bugs.
Can someone have a look please ?
Thanks.
--
David Marchand
next prev parent reply other threads:[~2018-06-12 7:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 8:15 David Marchand
2018-06-12 7:09 ` David Marchand [this message]
2018-06-12 8:38 ` Remy Horton
2018-06-13 15:39 ` Ferruh Yigit
2018-06-14 6:39 ` Remy Horton
2018-06-14 10:55 ` Ferruh Yigit
2018-06-14 19:33 ` Remy Horton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALwxeUsBYGb+0XEk4o-yb2xJ+4ZkJov5dL_E-_X3XZDwqUxD7Q@mail.gmail.com \
--to=david.marchand@6wind.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=remy.horton@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).