From: David Marchand <david.marchand@6wind.com>
To: Radu Nicolau <radu.nicolau@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Declan Doherty <declan.doherty@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
borisp@mellanox.com, aviadye@mellanox.com,
Thomas Monjalon <thomas@monjalon.net>,
sandeep.malik@nxp.com,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
shahafs@mellanox.com, Olivier Matz <olivier.matz@6wind.com>,
Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue
Date: Thu, 26 Oct 2017 12:36:06 +0200 [thread overview]
Message-ID: <CALwxeUsOAA8KOtSLT0RqNNRa3UW4s=g9ddDKkFEAyRijQbVkLQ@mail.gmail.com> (raw)
In-Reply-To: <1509013365-13819-3-git-send-email-radu.nicolau@intel.com>
On Thu, Oct 26, 2017 at 12:22 PM, Radu Nicolau <radu.nicolau@intel.com> wrote:
> Build fails when rte_security is disabled; make rte_security mandatory
> Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec")
>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> ---
> drivers/net/ixgbe/Makefile | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile
> index f03c426..c879828 100644
> --- a/drivers/net/ixgbe/Makefile
> +++ b/drivers/net/ixgbe/Makefile
> @@ -31,6 +31,12 @@
>
> include $(RTE_SDK)/mk/rte.vars.mk
>
> +ifneq ($(MAKECMDGOALS),clean)
> +ifneq ($(CONFIG_RTE_LIBRTE_SECURITY),y)
> +$(error "RTE_LIBRTE_SECURITY is required to build RTE_LIBRTE_IXGBE_PMD")
> +endif
> +endif
> +
> #
> # library name
> #
This is a no go for me unless you explain how it is impossible to
disable it in the code.
--
David Marchand
next prev parent reply other threads:[~2017-10-26 10:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 10:22 [dpdk-dev] [PATCH 0/3] Build fails when rte_security is disabled Radu Nicolau
2017-10-26 10:22 ` [dpdk-dev] [PATCH 1/3] crypto/dpaa2_sec: fix build issue Radu Nicolau
2017-10-26 10:22 ` [dpdk-dev] [PATCH 2/3] net/ixgbe: " Radu Nicolau
2017-10-26 10:36 ` David Marchand [this message]
2017-10-26 11:01 ` Radu Nicolau
2017-10-26 11:27 ` David Marchand
2017-10-26 11:39 ` Thomas Monjalon
2017-10-26 12:28 ` Radu Nicolau
2017-10-26 12:33 ` Thomas Monjalon
2017-10-26 12:59 ` Akhil Goyal
2017-10-26 13:07 ` Thomas Monjalon
2017-10-26 13:16 ` Akhil Goyal
2017-10-26 14:00 ` Thomas Monjalon
2017-10-26 11:30 ` Ananyev, Konstantin
2017-10-26 11:39 ` David Marchand
2017-10-26 12:30 ` Radu Nicolau
2017-10-26 12:33 ` Ananyev, Konstantin
2017-10-26 10:22 ` [dpdk-dev] [PATCH 3/3] examples/ipsec-secgw: " Radu Nicolau
2017-10-26 10:31 ` [dpdk-dev] [PATCH 0/3] Build fails when rte_security is disabled Akhil Goyal
2017-10-26 14:15 ` [dpdk-dev] [PATCH v2 " Radu Nicolau
2017-10-26 14:15 ` [dpdk-dev] [PATCH v2 1/3] net/ixgbe: fix build issue Radu Nicolau
2017-10-26 14:15 ` [dpdk-dev] [PATCH v2 2/3] examples/ipsec-secgw: " Radu Nicolau
2017-10-26 14:15 ` [dpdk-dev] [PATCH v2 3/3] crypto/dpaa2_sec: " Radu Nicolau
2017-10-26 15:27 ` [dpdk-dev] [PATCH v2 0/3] Build fails when rte_security is disabled David Marchand
2017-10-26 20:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALwxeUsOAA8KOtSLT0RqNNRa3UW4s=g9ddDKkFEAyRijQbVkLQ@mail.gmail.com' \
--to=david.marchand@6wind.com \
--cc=akhil.goyal@nxp.com \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=john.mcnamara@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=olivier.matz@6wind.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=radu.nicolau@intel.com \
--cc=sandeep.malik@nxp.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).