From: David Marchand <david.marchand@6wind.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] eal: add help option
Date: Tue, 3 Feb 2015 10:07:26 +0100 [thread overview]
Message-ID: <CALwxeUshnMCHBuo5RmipxWgw47PMoyBj6tEVE1WmH3Z6A8uwnA@mail.gmail.com> (raw)
In-Reply-To: <2737083.7r1iOF2V6p@xps13>
On Tue, Feb 3, 2015 at 9:20 AM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:
> 2015-02-03 07:33, David Marchand:
> > On Mon, Feb 2, 2015 at 6:44 PM, Thomas Monjalon <
> thomas.monjalon@6wind.com>
> > wrote:
> > [snip]
> > > @@ -340,6 +342,9 @@ eal_parse_args(int argc, char **argv)
> > > continue;
> > >
> > > switch (opt) {
> > > + case 'h':
> > > + eal_usage(prgname);
> > > + exit(EXIT_SUCCESS);
> > > default:
> > > if (opt < OPT_LONG_MIN_NUM && isprint(opt)) {
> > > RTE_LOG(ERR, EAL, "Option %c is not
> supported "
> > [snip]
> > > @@ -534,6 +536,10 @@ eal_parse_args(int argc, char **argv)
> > > continue;
> > >
> > > switch (opt) {
> > > + case 'h':
> > > + eal_usage(prgname);
> > > + exit(EXIT_SUCCESS);
> > > +
> > > /* force loading of external driver */
> > > case 'd':
> > > solib = malloc(sizeof(*solib));
> >
> > Why not move those two in common parser ?
>
> Because it's calling eal_usage() which is not callable from common parser.
> eal_usage() print usage for common and environment-specific options.
>
Oh right ...
Then, I suppose it is fine like this.
Acked-by: David Marchand <david.marchand@6wind.com>
--
David Marchand
next prev parent reply other threads:[~2015-02-03 9:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 18:07 [dpdk-dev] [PATCH 0/2] " Thomas Monjalon
2015-01-29 18:07 ` [dpdk-dev] [PATCH 1/2] eal: sort and align options lists Thomas Monjalon
2015-01-29 18:07 ` [dpdk-dev] [PATCH 2/2] eal: add help option Thomas Monjalon
2015-02-02 17:44 ` [dpdk-dev] [PATCH v2 0/2] " Thomas Monjalon
2015-02-02 17:44 ` [dpdk-dev] [PATCH v2 1/2] eal: sort and align options lists Thomas Monjalon
2015-02-03 6:26 ` David Marchand
2015-02-03 8:27 ` Thomas Monjalon
[not found] ` <1422899093-20207-3-git-send-email-thomas.monjalon@6wind.com>
2015-02-03 6:33 ` [dpdk-dev] [PATCH v2 2/2] eal: add help option David Marchand
2015-02-03 8:20 ` Thomas Monjalon
2015-02-03 9:07 ` David Marchand [this message]
2015-02-12 16:47 ` [dpdk-dev] [PATCH v3 0/2] " Thomas Monjalon
2015-02-12 16:47 ` [dpdk-dev] [PATCH v3 1/2] eal: sort and align options lists Thomas Monjalon
2015-02-12 16:47 ` [dpdk-dev] [PATCH v3 2/2] eal: add help option Thomas Monjalon
2015-02-13 10:50 ` [dpdk-dev] [PATCH v3 0/2] " David Marchand
2015-02-24 11:09 ` Thomas Monjalon
2015-02-13 12:57 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALwxeUshnMCHBuo5RmipxWgw47PMoyBj6tEVE1WmH3Z6A8uwnA@mail.gmail.com \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).