From: David Marchand <david.marchand@6wind.com>
To: Panu Matilainen <pmatilai@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 0/2] Provide reasonable default to -n
Date: Thu, 15 Oct 2015 14:03:47 +0200 [thread overview]
Message-ID: <CALwxeUtRcona8FfMkRyN16TkJXRGKxp+w3N32ZDkobc4NWsCKQ@mail.gmail.com> (raw)
In-Reply-To: <cover.1444909165.git.pmatilai@redhat.com>
Hello,
On Thu, Oct 15, 2015 at 1:49 PM, Panu Matilainen <pmatilai@redhat.com>
wrote:
> The number of memory channels is a truly obscure thing as a mandatory
> command line argument when its really just an optimization.
> Provide a reasonable default in mempool as suggested by Bruce Richardson
> and make the -n argument optional in EAL to make DPDK that little bit
> easier to use for a first-timer.
>
> Panu Matilainen (2):
> mempool: use a better default for number of memory channels
> eal: make the -n argument optional
>
> lib/librte_eal/common/eal_common_options.c | 8 +-------
> lib/librte_mempool/rte_mempool.c | 2 +-
> 2 files changed, 2 insertions(+), 8 deletions(-)
>
Looks good to me.
Thanks Panu.
Acked-by: David Marchand <david.marchand@6wind.com>
--
David Marchand
next prev parent reply other threads:[~2015-10-15 12:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 10:22 [dpdk-dev] [PATCH] eal: default to one memory channel if not specified Panu Matilainen
2015-10-14 11:45 ` David Marchand
2015-10-14 12:04 ` Panu Matilainen
2015-10-14 13:05 ` Bruce Richardson
2015-10-15 11:49 ` [dpdk-dev] [PATCH 0/2] Provide reasonable default to -n Panu Matilainen
2015-10-15 11:49 ` [dpdk-dev] [PATCH 1/2] mempool: use a better default for number of memory channels Panu Matilainen
2015-10-15 11:49 ` [dpdk-dev] [PATCH 2/2] eal: make the -n argument optional Panu Matilainen
2015-10-15 12:03 ` David Marchand [this message]
2015-10-26 16:51 ` [dpdk-dev] [PATCH 0/2] Provide reasonable default to -n Thomas Monjalon
2015-10-15 12:10 ` Mcnamara, John
2015-10-15 12:36 ` Panu Matilainen
2015-10-15 13:12 ` Mcnamara, John
2015-10-26 16:50 ` Thomas Monjalon
2015-10-26 16:56 ` Thomas Monjalon
2015-10-27 7:19 ` Panu Matilainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALwxeUtRcona8FfMkRyN16TkJXRGKxp+w3N32ZDkobc4NWsCKQ@mail.gmail.com \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=pmatilai@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).