From: David Marchand <david.marchand@6wind.com>
To: "Liu, Jijiang" <jijiang.liu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 5/8] driver/virtio:enqueue vhost TX offload
Date: Fri, 30 Oct 2015 13:14:58 +0100 [thread overview]
Message-ID: <CALwxeUtUDCfO4wMQk2TNzZxrM=af8=g_fvvWeTHHHrRCap3Aig@mail.gmail.com> (raw)
In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC22BC6494@SHSMSX101.ccr.corp.intel.com>
On Fri, Oct 30, 2015 at 12:45 PM, Liu, Jijiang <jijiang.liu@intel.com>
wrote:
>
> If the driver correctly reports negotiated offload capabilities (see my
> previous comment on patch 3), there is no need for the test on
> VIRTIO_NET_F_CSUM, because application is not supposed to ask for offloads
> on driver that do not support them.
>
>
>
>
>
> > If the driver correctly reports negotiated offload capabilities, then
> application in guest will set the ol_flags in mbuf based on these offload
> capabilities.
>
> If the VIRTIO_NET_F_CSUM is not enabled, and there is no need to call
> virtqueue_enqueue_offload() to check ol_flags in mbuf to see if the TX
> checksum and TSO is set ,and it will not effect on the performance of
> disabling TX checksum path as much as possible.
>
> So I think there is need for the check.
>
You are supposed to only handle mbuf with offloads if VIRTIO_NET_F_CSUM was
enabled in the first place through the capabilities.
So looking at ol_flags means that you implicitely check for
VIRTIO_NET_F_CSUM.
This is just an optimisation, so do as you like.
Anyway, I just want to confirm, is this patchset for 2.2 ?
--
David Marchand
next prev parent reply other threads:[~2015-10-30 12:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 4:46 [dpdk-dev] [PATCH 0/8] add vhost TX offload support Jijiang Liu
2015-10-21 4:46 ` [dpdk-dev] [PATCH 1/8] driver/virtio:add virtual addr for virtio net header Jijiang Liu
2015-10-26 7:07 ` Tan, Jianfeng
2015-10-21 4:46 ` [dpdk-dev] [PATCH 2/8] driver/virtio: record virtual address of " Jijiang Liu
2015-10-21 4:46 ` [dpdk-dev] [PATCH 3/8] driver/virtio:add vhost TX offload support capability in virtio-net Jijiang Liu
2015-10-29 12:44 ` David Marchand
2015-10-30 8:15 ` Liu, Jijiang
2015-10-21 4:46 ` [dpdk-dev] [PATCH 4/8] driver/virtio:add vhost TX offload support capability Jijiang Liu
2015-10-21 4:46 ` [dpdk-dev] [PATCH 5/8] driver/virtio:enqueue vhost TX offload Jijiang Liu
2015-10-29 14:15 ` David Marchand
2015-10-30 11:45 ` Liu, Jijiang
2015-10-30 12:14 ` David Marchand [this message]
2015-10-30 12:21 ` Liu, Jijiang
2015-10-21 4:46 ` [dpdk-dev] [PATCH 6/8] lib/librte_vhost:dequeue " Jijiang Liu
2015-10-21 4:46 ` [dpdk-dev] [PATCH 7/8] examples/vhost:support TX offload in vhost sample Jijiang Liu
2015-10-21 4:46 ` [dpdk-dev] [PATCH 8/8] app/testpmd:modify MAC address of csum forwarding Jijiang Liu
2015-10-26 6:45 ` [dpdk-dev] [PATCH 0/8] add vhost TX offload support Liu, Jijiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALwxeUtUDCfO4wMQk2TNzZxrM=af8=g_fvvWeTHHHrRCap3Aig@mail.gmail.com' \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=jijiang.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).