From: David Marchand <david.marchand@6wind.com>
To: Yangchao Zhou <zhouyates@gmail.com>
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] pci:fix missing free
Date: Fri, 30 Sep 2016 17:19:07 +0200 [thread overview]
Message-ID: <CALwxeUtVz_A-xqRN2xEwicuxv9mru=BUivKCLf_0BG3ZtC4Vnw@mail.gmail.com> (raw)
In-Reply-To: <1475113270-21983-1-git-send-email-zhouyates@gmail.com>
Hello,
On Thu, Sep 29, 2016 at 3:41 AM, Yangchao Zhou <zhouyates@gmail.com> wrote:
> Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
> ---
> lib/librte_eal/common/eal_common_pci.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c
> index 7248c38..eb44998 100644
> --- a/lib/librte_eal/common/eal_common_pci.c
> +++ b/lib/librte_eal/common/eal_common_pci.c
> @@ -378,6 +378,7 @@ rte_eal_pci_detach(const struct rte_pci_addr *addr)
> goto err_return;
>
> TAILQ_REMOVE(&pci_device_list, dev, next);
> + free(dev);
> return 0;
> }
> return -1;
> --
> 1.7.1
>
For the title, how about:
pci: fix memory leak when detaching devices
Afaics the fixes tag would be :
Fixes: dbe6b4b61b0e ("pci: probe or close device")
+ CC stable
--
David Marchand
next parent reply other threads:[~2016-09-30 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4622854.nVE6J4R6pe@xps13>
[not found] ` <1475113270-21983-1-git-send-email-zhouyates@gmail.com>
2016-09-30 15:19 ` David Marchand [this message]
2016-09-30 15:27 ` David Marchand
2016-10-04 8:07 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALwxeUtVz_A-xqRN2xEwicuxv9mru=BUivKCLf_0BG3ZtC4Vnw@mail.gmail.com' \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thomas.monjalon@6wind.com \
--cc=zhouyates@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).