From: David Marchand <david.marchand@6wind.com>
To: Wei Dai <wei.dai@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] eal/linuxapp: fix return value check of mknod()
Date: Wed, 16 Nov 2016 12:23:40 +0100 [thread overview]
Message-ID: <CALwxeUtk+Tq6FLqLG+=+pK_CECkhzTXYqbP0nO=2uc9cy-dQhA@mail.gmail.com> (raw)
In-Reply-To: <1479264047-67966-1-git-send-email-wei.dai@intel.com>
Hello Wei,
On Wed, Nov 16, 2016 at 3:40 AM, Wei Dai <wei.dai@intel.com> wrote:
> In function pci_mknod_uio_dev() in lib/librte_eal/eal/eal_pci_uio.c,
> The return value of mknod() is ret, not f got by fopen().
> So the value of ret should be checked for mknod().
>
> Fixes: 67c536bdad93 ("pci: move uio mapping in a dedicated file")
The commit you are pointing is just moving the code.
I would incriminate f7f97c16048e ("pci: add option --create-uio-dev to
run without hotplug")
The rest looks good to me.
--
David Marchand
next prev parent reply other threads:[~2016-11-16 11:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 2:12 [dpdk-dev] [PATCH] " Zhiyong Yang
2016-11-16 2:40 ` [dpdk-dev] [PATCH v2] " Wei Dai
2016-11-16 3:28 ` Lu, Wenzhuo
2016-11-16 11:04 ` Ferruh Yigit
2016-11-16 15:17 ` Dai, Wei
2016-11-16 11:23 ` David Marchand [this message]
2016-11-16 15:18 ` Dai, Wei
2016-11-17 6:47 ` [dpdk-dev] [PATCH v3] " Wei Dai
2016-12-06 10:44 ` Olivier Matz
2016-12-06 11:01 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALwxeUtk+Tq6FLqLG+=+pK_CECkhzTXYqbP0nO=2uc9cy-dQhA@mail.gmail.com' \
--to=david.marchand@6wind.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=wei.dai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).