From: David Marchand <david.marchand@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Helin Zhang <helin.zhang@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] net/ixgbe: move PCI device ids to the driver
Date: Wed, 10 Aug 2016 14:07:03 +0200 [thread overview]
Message-ID: <CALwxeUto6T9SRgexgY46egksDHmpCG7KfBfj2UOb9+6k6eEzaA@mail.gmail.com> (raw)
In-Reply-To: <57A84C89.7050107@intel.com>
On Mon, Aug 8, 2016 at 11:10 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 8/8/2016 7:36 AM, David Marchand wrote:
>> The only thing that bothers me using this ("unsynchronised") internal
>> pci device list is that, if people were using the ethtool part of kni,
>> there would now be devices that won't be recognised anymore.
>> Is it intentional ?
>
> I am aware that the list changed, but wasn't sure about updating the
> list in drivers or not.
>
> If a device is not listed in driver's pci device id table, it may not be
> supported, so ethtool may give wrong output, or it may just be missing,
> this is hard to know without testing (although this was the case before
> this patch)
>
> Since it is easy to add new id, and we are at the beginning of the
> release, I was thinking if somebody reports KNI ethotool support is
> missing for a specific device, we can add it instead of adding all by
> default.
Ok for me and with this we can know if this ethtool part is used :-)
--
David Marchand
next prev parent reply other threads:[~2016-08-10 12:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 14:09 [dpdk-dev] [PATCH 0/3] remove rte_pci_dev_ids.h Ferruh Yigit
2016-08-05 14:09 ` [dpdk-dev] [PATCH 1/3] net/ixgbe: move PCI device ids to the driver Ferruh Yigit
2016-08-08 6:36 ` David Marchand
2016-08-08 9:10 ` Ferruh Yigit
2016-08-10 12:07 ` David Marchand [this message]
2016-08-05 14:09 ` [dpdk-dev] [PATCH 2/3] net/igb: " Ferruh Yigit
2016-08-05 14:09 ` [dpdk-dev] [PATCH 3/3] eal: remove rte_pci_dev_ids.h Ferruh Yigit
2016-08-06 12:55 ` Thomas Monjalon
2016-08-08 6:20 ` David Marchand
2016-08-23 13:35 ` Thomas Monjalon
2016-08-23 13:37 ` [dpdk-dev] [PATCH 0/3] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALwxeUto6T9SRgexgY46egksDHmpCG7KfBfj2UOb9+6k6eEzaA@mail.gmail.com \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=helin.zhang@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=thomas.monjalon@6wind.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).