From: David Marchand <david.marchand@6wind.com>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Felix Marti <felix@chelsio.com>,
Nirranjan Kirubaharan <nirranjan@chelsio.com>,
Kumar Sanghvi <kumaras@chelsio.com>
Subject: Re: [dpdk-dev] [PATCH v3 1/3] nic_uio: Fix to allow any device to be bound to nic_uio
Date: Tue, 21 Jul 2015 08:14:34 +0200 [thread overview]
Message-ID: <CALwxeUu1JPwFNKgR7Rw7o_kZQm-wnBzEnqnWL9Jz-YsCg8Jg2A@mail.gmail.com> (raw)
In-Reply-To: <5e6315c050b27539d567799a5b35c8cc9395cacf.1437392218.git.rahul.lakkireddy@chelsio.com>
On Mon, Jul 20, 2015 at 7:31 PM, Rahul Lakkireddy <
rahul.lakkireddy@chelsio.com> wrote:
> nic_uio requires the pci ids to be present in rte_pci_dev_ids.h in order to
> bind the devices to nic_uio. However, it's better to remove this
> whitelist of
> pci ids, and instead rely on hw.nic_uio.bdfs kenv parameter to allow
> binding
> any device to nic_uio.
>
> Suggested-by: David Marchand <david.marchand@6wind.com>
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> Signed-off-by: Kumar Sanghvi <kumaras@chelsio.com>
> ---
> v3:
> - Use checks for bus, slot, and function info instead of vendor and device
> during nic_uio probe for better consistency.
>
Looks good to me.
Acked-by: David Marchand <david.marchand@6wind.com>
Thanks Rahul.
--
David Marchand
next prev parent reply other threads:[~2015-07-21 6:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 18:20 [dpdk-dev] [PATCH 0/3] cxgbe: Fix compilation and enable FreeBSD support for CXGBE PMD Rahul Lakkireddy
2015-07-17 18:20 ` [dpdk-dev] [PATCH 1/3] nic_uio: Fix to allow any device to be bound to nic_uio Rahul Lakkireddy
2015-07-19 23:23 ` Thomas Monjalon
2015-07-17 18:20 ` [dpdk-dev] [PATCH 2/3] cxgbe: Enable and fix FreeBSD compilation for CXGBE PMD Rahul Lakkireddy
2015-07-17 18:20 ` [dpdk-dev] [PATCH 3/3] doc: Update documentation to reflect FreeBSD support " Rahul Lakkireddy
2015-07-20 6:41 ` [dpdk-dev] [PATCH v2 0/3] cxgbe: Fix compilation and enable " Rahul Lakkireddy
2015-07-20 6:41 ` [dpdk-dev] [PATCH v2 1/3] nic_uio: Fix to allow any device to be bound to nic_uio Rahul Lakkireddy
2015-07-20 7:43 ` David Marchand
2015-07-20 12:07 ` Rahul Lakkireddy
2015-07-20 6:41 ` [dpdk-dev] [PATCH v2 2/3] cxgbe: Enable and fix FreeBSD compilation for CXGBE PMD Rahul Lakkireddy
2015-07-20 6:41 ` [dpdk-dev] [PATCH v2 3/3] doc: Update documentation to reflect FreeBSD support " Rahul Lakkireddy
2015-07-20 17:31 ` [dpdk-dev] [PATCH v3 0/3] cxgbe: Fix compilation and enable " Rahul Lakkireddy
2015-07-20 17:31 ` [dpdk-dev] [PATCH v3 1/3] nic_uio: Fix to allow any device to be bound to nic_uio Rahul Lakkireddy
2015-07-21 6:14 ` David Marchand [this message]
2015-07-20 17:31 ` [dpdk-dev] [PATCH v3 2/3] cxgbe: Enable and fix FreeBSD compilation for CXGBE PMD Rahul Lakkireddy
2015-07-20 17:31 ` [dpdk-dev] [PATCH v3 3/3] doc: Update documentation to reflect FreeBSD support " Rahul Lakkireddy
2015-07-21 9:40 ` [dpdk-dev] [PATCH v3 0/3] cxgbe: Fix compilation and enable " Bruce Richardson
2015-07-22 13:11 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALwxeUu1JPwFNKgR7Rw7o_kZQm-wnBzEnqnWL9Jz-YsCg8Jg2A@mail.gmail.com \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=felix@chelsio.com \
--cc=kumaras@chelsio.com \
--cc=nirranjan@chelsio.com \
--cc=rahul.lakkireddy@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).