DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@6wind.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Mcnamara, John" <john.mcnamara@intel.com>,
	 michalx.k.jastrzebski@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] eal: Fix wrong resource release while unmapping pci devices
Date: Fri, 17 Jun 2016 14:12:05 +0200	[thread overview]
Message-ID: <CALwxeUvAbCDQHtyFMh0QG0irFU1d0mN8-2zBQPRHFzEqDZ3NyA@mail.gmail.com> (raw)
In-Reply-To: <1466044391-3210-2-git-send-email-mukawa@igel.co.jp>

On Thu, Jun 16, 2016 at 4:33 AM, Tetsuya Mukawa <mukawa@igel.co.jp> wrote:
> This patch fixes wrong resource release of pci_uio_unmap().
> The 'path' member of mapped_pci_resource structure is allocated by
> primary process, but currently it will be freed by both primary
> and secondary process.
> The patch fixes to be freed by only primary process.
>
> Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>

Wrong headline uppercase:
    eal: Fix wrong resource release while unmapping pci devices
Wrong headline lowercase:
    eal: Fix wrong resource release while unmapping pci devices
Missing 'Fixes' tag:
    eal: Fix wrong resource release while unmapping pci devices

Then you can add my ack.


-- 
David Marchand

  reply	other threads:[~2016-06-17 12:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-15  3:26 [dpdk-dev] [PATCH] eal: Fix wrong error checking of rte_eal_parse_devargs_str() Tetsuya Mukawa
2016-06-15 14:48 ` David Marchand
2016-06-16  2:03   ` Tetsuya Mukawa
2016-06-16  2:33 ` [dpdk-dev] [PATCH v2] eal: Fix wrong error checking while parsing device arguments Tetsuya Mukawa
2016-06-15  3:26   ` [dpdk-dev] [PATCH] eal: Fix resource leak of pci_uio_map_secondary() Tetsuya Mukawa
2016-06-15 14:45     ` David Marchand
2016-06-16  2:03       ` Tetsuya Mukawa
2016-06-16  2:33     ` [dpdk-dev] [PATCH v2] eal: Fix resource leak while secondary process maps pci devices Tetsuya Mukawa
2016-06-17 12:28       ` David Marchand
2016-06-20  2:19         ` Tetsuya Mukawa
2016-06-20  8:50           ` Thomas Monjalon
2016-06-15  3:27   ` [dpdk-dev] [PATCH] eal: Fix wrong resource release of pci_uio_unmap() Tetsuya Mukawa
2016-06-15 15:01     ` David Marchand
2016-06-16  2:33     ` [dpdk-dev] [PATCH v2] eal: Fix wrong resource release while unmapping pci devices Tetsuya Mukawa
2016-06-17 12:12       ` David Marchand [this message]
2016-06-20  8:50         ` Thomas Monjalon
2016-06-17 12:10   ` [dpdk-dev] [PATCH v2] eal: Fix wrong error checking while parsing device arguments David Marchand
2016-06-20  8:49     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALwxeUvAbCDQHtyFMh0QG0irFU1d0mN8-2zBQPRHFzEqDZ3NyA@mail.gmail.com \
    --to=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=michalx.k.jastrzebski@intel.com \
    --cc=mukawa@igel.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).