From: David Marchand <david.marchand@6wind.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] no need to test for NULL when freeing
Date: Thu, 21 Jan 2016 12:33:23 +0100 [thread overview]
Message-ID: <CALwxeUvtTzXn0T19FdR9R7zH496Dm5huMDWEVOhjUkXwn5a2Kw@mail.gmail.com> (raw)
In-Reply-To: <3415689.rt0oTMTjK5@xps13>
On Thu, Jan 21, 2016 at 12:30 PM, Thomas Monjalon
<thomas.monjalon@6wind.com> wrote:
> 2016-01-21 12:23, David Marchand:
>> free() already handles NULL pointer.
>>
>> Signed-off-by: David Marchand <david.marchand@6wind.com>
>> ---
>> app/test/test_devargs.c | 3 +-
>> app/test/test_link_bonding.c | 6 ++--
>> app/test/test_pci.c | 3 +-
>> app/test/test_ring.c | 36 ++++++++--------------
>> drivers/net/xenvirt/rte_eth_xenvirt.c | 6 ++--
>> drivers/net/xenvirt/rte_mempool_gntalloc.c | 9 ++----
>> examples/ip_pipeline/cpu_core_map.c | 3 +-
>> .../pipeline/pipeline_flow_classification_be.c | 6 ++--
>> examples/vhost_xen/vhost_monitor.c | 3 +-
>> examples/vhost_xen/xenstore_parse.c | 33 +++++++-------------
>> lib/librte_eal/common/eal_common_devargs.c | 3 +-
>> lib/librte_eal/linuxapp/eal/eal_memory.c | 3 +-
>> lib/librte_ether/rte_ethdev.c | 6 ++--
>> lib/librte_kvargs/rte_kvargs.c | 4 +--
>> 14 files changed, 41 insertions(+), 83 deletions(-)
>
> Have you used a coccinelle script?
Nop, some shell script of mine with manual checks.
--
David Marchand
next prev parent reply other threads:[~2016-01-21 11:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 11:23 David Marchand
2016-01-21 11:30 ` Thomas Monjalon
2016-01-21 11:33 ` David Marchand [this message]
2016-01-27 14:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALwxeUvtTzXn0T19FdR9R7zH496Dm5huMDWEVOhjUkXwn5a2Kw@mail.gmail.com \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).