From: David Marchand <david.marchand@6wind.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Olivier Matz <olivier.matz@6wind.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/3] mbuf: add a non fatal sanity check helper
Date: Mon, 10 Sep 2018 07:56:38 +0200 [thread overview]
Message-ID: <CALwxeUvtjJzkbQe4g1+E6ciz25vYKaHdRqYFvEy6dhx8quOjRQ@mail.gmail.com> (raw)
In-Reply-To: <20180910054547.18494-3-david.marchand@6wind.com>
On Mon, Sep 10, 2018 at 7:45 AM, David Marchand
<david.marchand@6wind.com> wrote:
> Let's add a little helper that does the same as rte_mbuf_sanity_check but
> without the panic.
>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
> ---
> lib/librte_mbuf/Makefile | 2 +
> lib/librte_mbuf/meson.build | 2 +
> lib/librte_mbuf/rte_mbuf.c | 74 ++++++++++++++++++++--------
> lib/librte_mbuf/rte_mbuf.h | 23 +++++++++
> lib/librte_mbuf/rte_mbuf_version.map | 6 +++
Applied a little patch on devtools/check-symbol-change.sh
@@ -115,7 +115,7 @@ check_for_rule_violations()
if [ $? -ne 0 ]
then
echo -n "ERROR: symbol $symname "
- echo -n "is added in a section "
+ echo -n "is added in $secname section "
echo -n "other than the EXPERIMENTAL "
echo "section of the version map"
ret=1
And here is what I get when I check my patch with it:
marchand@gribouille:~/git/dpdk$ ./devtools/check-symbol-change.sh
sanity/0002-mbuf-add-a-non-fatal-sanity-check-helper.patch
ERROR: symbol rte_mbuf_check is added in +EXPERIMENTAL section other
than the EXPERIMENTAL section of the version map
Is this because the EXPERIMENTAL section is added in the same patch ?
--
David Marchand
next prev parent reply other threads:[~2018-09-10 5:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 5:45 [dpdk-dev] [PATCH 0/3] segment sanity checks David Marchand
2018-09-10 5:45 ` [dpdk-dev] [PATCH 1/3] mbuf: add sanity checks on segment metadata David Marchand
2018-09-11 18:16 ` Yongseok Koh
2018-09-13 6:55 ` David Marchand
2018-10-09 9:11 ` Olivier Matz
2018-09-10 5:45 ` [dpdk-dev] [PATCH 2/3] mbuf: add a non fatal sanity check helper David Marchand
2018-09-10 5:56 ` David Marchand [this message]
2018-09-10 8:12 ` Andrew Rybchenko
2018-09-10 8:24 ` David Marchand
2018-09-10 8:33 ` Andrew Rybchenko
2018-10-09 9:10 ` Olivier Matz
2018-09-10 5:45 ` [dpdk-dev] [PATCH 3/3] app/testpmd: add sanity checks on received/sent packets David Marchand
2018-09-25 13:17 ` Iremonger, Bernard
2018-09-25 15:11 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALwxeUvtjJzkbQe4g1+E6ciz25vYKaHdRqYFvEy6dhx8quOjRQ@mail.gmail.com \
--to=david.marchand@6wind.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=nhorman@tuxdriver.com \
--cc=olivier.matz@6wind.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).