From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "Xing, Beilei" <beilei.xing@intel.com>,
"Dai, Wei" <wei.dai@intel.com>,
"Zhang, Helin" <helin.zhang@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 0/5] ixgbe: fix bugs or just improve.
Date: Thu, 12 Apr 2018 10:11:15 +0800 [thread overview]
Message-ID: <CAMDZJNWgG76TWXDtVhqwDV8C0FittmiV37mmKmE2xriYADVoKw@mail.gmail.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E706115318FA76@SHSMSX103.ccr.corp.intel.com>
On Wed, Apr 11, 2018 at 8:21 PM, Zhang, Qi Z <qi.z.zhang@intel.com> wrote:
> Hi tonghao:
>
>> -----Original Message-----
>> From: Tonghao Zhang [mailto:xiangxia.m.yue@gmail.com]
>> Sent: Monday, April 9, 2018 8:53 AM
>> To: Zhang, Qi Z <qi.z.zhang@intel.com>
>> Cc: Xing, Beilei <beilei.xing@intel.com>; Dai, Wei <wei.dai@intel.com>; Zhang,
>> Helin <helin.zhang@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
>> dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v3 0/5] ixgbe: fix bugs or just improve.
>>
>> On Wed, Apr 4, 2018 at 10:48 AM, Zhang, Qi Z <qi.z.zhang@intel.com> wrote:
>> >
>> >
>> >> -----Original Message-----
>> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tonghao Zhang
>> >> Sent: Thursday, March 8, 2018 6:57 PM
>> >> To: Xing, Beilei <beilei.xing@intel.com>; Dai, Wei
>> >> <wei.dai@intel.com>; Zhang, Helin <helin.zhang@intel.com>; Lu,
>> >> Wenzhuo <wenzhuo.lu@intel.com>
>> >> Cc: dev@dpdk.org; Tonghao Zhang <xiangxia.m.yue@gmail.com>
>> >> Subject: Re: [dpdk-dev] [PATCH v3 0/5] ixgbe: fix bugs or just improve.
>> >>
>> >> ping ....
>> >>
>> >> On Mon, Feb 5, 2018 at 8:51 AM, <xiangxia.m.yue@gmail.com> wrote:
>> >> > From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>> >> >
>> >> > The patches in the patchset have no dependency. But all of them is
>> >> > about ixgbe or ixgbevf. The patch 1 and 2 add the itr configuration
>> >> > for ixgbe and ixgbevf, the user and developer can configure it for
>> >> > their platform. Other patches refine the ixgbe or ixgbevf.
>> >> >
>> >> > v2 --> v3:
>> >> > remove the patch: http://dpdk.org/dev/patchwork/patch/33698
>> >> >
>> >> > Tonghao Zhang (5):
>> >> > net/ixgbevf: set the inter-interrupt interval for EITR.
>> >> > net/ixgbe: set the ITR via configuration.
>> >> > net/ixgbe: write disable to ITR counter.
>> >> > net/ixgbevf: save IXGBE_VTEIMS to intr->mask for performance.
>> >> > net/ixgbe: remove the unnecessary call rte_intr_enable.
>> >> >
>> >> > config/common_base | 2 +
>> >> > drivers/net/ixgbe/ixgbe_ethdev.c | 79
>> >> > +++++++++++++++++++++++-----------------
>> >> > drivers/net/ixgbe/ixgbe_ethdev.h | 12 ++++++
>> >> > drivers/net/ixgbe/ixgbe_rxtx.c | 3 +-
>> >> > 4 files changed, 61 insertions(+), 35 deletions(-)
>> >> >
>> >> > --
>> >> > 1.8.3.1
>> >> >
>> >
>> > Review-by: Qi Zhang <qi.z.zhang@intel.com>
>> >
>> > Minor typo error in patch1 need to be fixed.
>> Should I sent v4 ?
>
> One more capture on patch 5,
> https://dpdk.org/dev/patchwork/patch/36433/
> Remove rte_intr_enable in interrupt handler may not work with legacy interrupt mode which ixgbe supposed to support.
Remove it, and thanks for your review.
> It's better to so some test on that mode if you want patch 5 be applied,
> or we can just remove patch 5 and I'd like to ack patch 1-4, what do you think?
>
> Regards
> Qi
>
>
next prev parent reply other threads:[~2018-04-12 2:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 0:51 xiangxia.m.yue
2018-02-05 0:51 ` [dpdk-dev] [PATCH v3 1/5] net/ixgbevf: set the inter-interrupt interval for EITR xiangxia.m.yue
2018-02-05 0:51 ` [dpdk-dev] [PATCH v3 2/5] net/ixgbe: set the ITR via configuration xiangxia.m.yue
2018-02-05 0:51 ` [dpdk-dev] [PATCH v3 3/5] net/ixgbe: write disable to ITR counter xiangxia.m.yue
2018-02-05 0:51 ` [dpdk-dev] [PATCH v3 4/5] net/ixgbevf: save IXGBE_VTEIMS to intr->mask for performance xiangxia.m.yue
2018-02-05 0:51 ` [dpdk-dev] [PATCH v3 5/5] net/ixgbe: remove the unnecessary call rte_intr_enable xiangxia.m.yue
2018-03-08 10:56 ` [dpdk-dev] [PATCH v3 0/5] ixgbe: fix bugs or just improve Tonghao Zhang
2018-04-04 2:48 ` Zhang, Qi Z
2018-04-09 0:53 ` Tonghao Zhang
2018-04-11 12:21 ` Zhang, Qi Z
2018-04-12 2:11 ` Tonghao Zhang [this message]
2018-04-12 5:21 ` Zhang, Qi Z
2018-04-16 4:19 ` Zhang, Helin
2018-03-22 13:01 xiangxia.m.yue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMDZJNWgG76TWXDtVhqwDV8C0FittmiV37mmKmE2xriYADVoKw@mail.gmail.com \
--to=xiangxia.m.yue@gmail.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=wei.dai@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).