From: Shepard Siegel <shepard.siegel@atomicrules.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: John Miller <john.miller@atomicrules.com>,
dev@dpdk.org, Ed Czeck <ed.czeck@atomicrules.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/ark: allow unique user data for each port in extension calls
Date: Fri, 23 Jun 2017 06:06:35 -0400 [thread overview]
Message-ID: <CAMMLSKCWh-0C3w4_hR35GfRg5p0==z0y-uMw9Jc073J2GmWhrQ@mail.gmail.com> (raw)
In-Reply-To: <258b76a4-dec7-0ccc-e568-581cf5cbc09c@intel.com>
Hi Ferruh,
I was absent from the code review John Miller and Ed Czeck held for earlier
this week for this patch set. John and Ed are both on a long weekend this
weekend. If my reply below is correct and sufficient, please ack this patch
set. Otherwise, no reply is needed and please hold this open until next
Monday when John will respond.
The Arkville net/ark PMD has the unique challenge of supporting a plurality
of MACs through singleton ingress and egress AXI interfaces in hardware.
Arkville is in the DPDK business of mbuf structures and data-moving; and
does not itself have a concept of line-rate, MTU, and other MAC-centric
properties. The extension calls, and the unique user data for each port in
the extension calls provide users of Arkville and the net/ark PMD a DPDK
normalized way of accessing their MAC parameters, regardless of how many
MACs they have instanced in their Arkville DPDK device.
-Shep
Shepard Siegel, CTO
atomicrules.com
On Fri, Jun 23, 2017 at 5:21 AM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:
> On 6/22/2017 1:30 PM, John Miller wrote:
> > Provide unique user data pointer in the extension calls for
> > each port.
>
> Hi John,
>
> Can you please give more details about why this is done. I can see in
> adapter data user_data pointer kept per port now, but why? What was
> observed with previous code? If this is to fix something, what we should
> expect to be fixed?
>
> And there is mtu_set implementation, is it related modification? Can be
> separated to another patch?
>
> Thanks,
> ferruh
>
> >
> > Signed-off-by: John Miller <john.miller@atomicrules.com>
>
> <...>
>
>
next prev parent reply other threads:[~2017-06-23 10:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 12:30 John Miller
2017-06-22 12:30 ` [dpdk-dev] [PATCH 2/2] net/ark: fix bug in stats_reset operation John Miller
2017-06-23 9:21 ` [dpdk-dev] [PATCH 1/2] net/ark: allow unique user data for each port in extension calls Ferruh Yigit
2017-06-23 10:06 ` Shepard Siegel [this message]
2017-06-28 10:08 ` [dpdk-dev] [PATCH v2 0/3] net/ark: augment user extension and bug fix John Miller
2017-06-28 10:08 ` [dpdk-dev] [PATCH v2 1/3] net/ark: allow unique user data for each port in extension calls John Miller
2017-06-28 10:08 ` [dpdk-dev] [PATCH v2 2/3] net/ark: add set_mtu call to user extension API John Miller
2017-06-28 10:08 ` [dpdk-dev] [PATCH v2 3/3] net/ark: fix bug in stats_reset operation John Miller
2017-06-28 12:39 ` [dpdk-dev] [PATCH v2 0/3] net/ark: augment user extension and bug fix Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMMLSKCWh-0C3w4_hR35GfRg5p0==z0y-uMw9Jc073J2GmWhrQ@mail.gmail.com' \
--to=shepard.siegel@atomicrules.com \
--cc=dev@dpdk.org \
--cc=ed.czeck@atomicrules.com \
--cc=ferruh.yigit@intel.com \
--cc=john.miller@atomicrules.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).