From: Ashish Sadanandan <ashish.sadanandan@gmail.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, john.levon@nutanix.com, stable@dpdk.org
Subject: Re: [PATCH v2 1/1] eal/linux: reject --huge-dir not parent of mountpt
Date: Wed, 4 Jan 2023 11:17:52 -0700 [thread overview]
Message-ID: <CAN44U21fDkVG9oz8R6VwBkXnpOp0DFyTXK+G5b4_sCXGC4jD7g@mail.gmail.com> (raw)
In-Reply-To: <20230104142456.320fc95a@sovereign>
[-- Attachment #1: Type: text/plain, Size: 618 bytes --]
On Wed, Jan 4, 2023 at 4:24 AM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
wrote:
> 2023-01-03 17:00 (UTC-0700), Ashish Sadanandan:
> > The code added for allowing --huge-dir to specify hugetlbfs
> > sub-directories has a bug where it incorrectly matches mounts that
> > contain a prefix of the specified --huge-dir.
> >
>
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
>
Thanks for reviewing
>
> The second one can be done before the loop.
> Please declare all variables at the beginning of the block per code style.
>
Done
>
> Nit: maybe a single comment for both conditions would be more clear:
>
Done
[-- Attachment #2: Type: text/html, Size: 1426 bytes --]
next prev parent reply other threads:[~2023-01-04 18:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 18:57 [PATCH 1/1] eal/linux: reject mountpt shorter than --huge-dir Ashish Sadanandan
2023-01-03 23:53 ` Ashish Sadanandan
2023-01-04 0:00 ` [PATCH v2 1/1] eal/linux: reject --huge-dir not parent of mountpt Ashish Sadanandan
2023-01-04 11:24 ` Dmitry Kozlyuk
2023-01-04 18:17 ` Ashish Sadanandan [this message]
2023-01-04 16:22 ` John Levon
2023-01-04 18:17 ` Ashish Sadanandan
2023-01-04 18:17 ` [PATCH v3 " Ashish Sadanandan
2023-01-09 1:52 ` [PATCH v4 1/1] eal/linux: reject mountpt not parent of --huge-dir Ashish Sadanandan
2023-01-11 12:11 ` John Levon
2023-01-16 18:25 ` Ashish Sadanandan
2023-02-10 11:04 ` David Marchand
2023-02-10 11:01 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN44U21fDkVG9oz8R6VwBkXnpOp0DFyTXK+G5b4_sCXGC4jD7g@mail.gmail.com \
--to=ashish.sadanandan@gmail.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=john.levon@nutanix.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).