From: Rushil Gupta <rushilg@google.com>
To: Levend Sayar <levendsayar@gmail.com>
Cc: junfeng.guo@intel.com, dev@dpdk.org
Subject: Re: [PATCH 1/2] net/gve: change offloading capability
Date: Thu, 16 Feb 2023 12:14:30 -0800 [thread overview]
Message-ID: <CANzqiF7hy_gN9BwuHWW-J_gOmwHSn+2n68Lx09qYndTqwuKB+A@mail.gmail.com> (raw)
In-Reply-To: <20230216185814.27830-1-levendsayar@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1066 bytes --]
Makes sense. The virtual device only does L4 checksum.
Acked-by: Rushil Gupta <rushilg@google.com>
On Thu, Feb 16, 2023 at 10:58 AM Levend Sayar <levendsayar@gmail.com> wrote:
> Google Virtual NIC is not doing IPv4 checksummimg.
> Removed that capability from PMD.
>
> Signed-off-by: Levend Sayar <levendsayar@gmail.com>
> ---
> drivers/net/gve/gve_ethdev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c
> index 06d1b796c8..fef2458a16 100644
> --- a/drivers/net/gve/gve_ethdev.c
> +++ b/drivers/net/gve/gve_ethdev.c
> @@ -282,7 +282,6 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
> dev_info->rx_offload_capa = 0;
> dev_info->tx_offload_capa =
> RTE_ETH_TX_OFFLOAD_MULTI_SEGS |
> - RTE_ETH_TX_OFFLOAD_IPV4_CKSUM |
> RTE_ETH_TX_OFFLOAD_UDP_CKSUM |
> RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
> RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
> --
> 2.37.1 (Apple Git-137.1)
>
>
[-- Attachment #2: Type: text/html, Size: 1707 bytes --]
next prev parent reply other threads:[~2023-02-16 20:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 18:58 Levend Sayar
2023-02-16 18:58 ` [PATCH 2/2] net/gve: add extended statistics Levend Sayar
2023-02-17 12:34 ` Ferruh Yigit
2023-02-19 0:26 ` Levend Sayar
2023-02-19 20:09 ` Ferruh Yigit
2023-02-19 20:37 ` Levend Sayar
2023-02-16 20:14 ` Rushil Gupta [this message]
2023-02-17 9:07 ` [PATCH 1/2] net/gve: change offloading capability Levend Sayar
2023-02-17 9:11 ` Guo, Junfeng
2023-02-17 9:15 ` Levend Sayar
2023-02-20 15:43 ` Ferruh Yigit
-- strict thread matches above, loose matches on Subject: below --
2023-02-10 13:05 Levend Sayar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANzqiF7hy_gN9BwuHWW-J_gOmwHSn+2n68Lx09qYndTqwuKB+A@mail.gmail.com \
--to=rushilg@google.com \
--cc=dev@dpdk.org \
--cc=junfeng.guo@intel.com \
--cc=levendsayar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).