From: Jakub Palider <jpalider@gmail.com>
To: Marcin Wojtas <mw@semihalf.com>
Cc: dev@dpdk.org, "Jan Mędala" <jan.medala@outlook.com>,
netanel@amazon.com, evgenys@amazon.com, matua@amazon.com,
gtzalik@amazon.com, igorch@amazon.com, mk@semihalf.com
Subject: Re: [dpdk-dev] [PATCH v2 0/4] Ena PMD fixes
Date: Tue, 11 Apr 2017 00:20:41 +0200 [thread overview]
Message-ID: <CAO-cEe=UtYoA=9PxtByeaLV_KyfhoQCQ6f2kqCs7BWZ_om06yQ@mail.gmail.com> (raw)
In-Reply-To: <1491834491-13944-1-git-send-email-mw@semihalf.com>
On Mon, Apr 10, 2017 at 4:28 PM, Marcin Wojtas <mw@semihalf.com> wrote:
> Hi,
>
> I sent second version of a patchset with various fixes for ena PMD.
> All remarks after v1 review have been taken into account. Details
> can be found in the changelog below.
>
> We are looking forward to any comments or remarks.
>
> Best regards,
> Marcin
>
> Changelog:
> v1 -> v2
> * 1/4:
> - Part of the changes related to the allocation of wrong amount of Rx
> descriptors from patch 2 were moved to patch 1
> * 2/4:
> - Remove additional variable desc_to_refill
> - Update desc_to_use after reading all descriptors - significant diff
> reduction
> - Update information why next_to_use must be assigned before call of
> the
> ena_rx_populate()
> - Update commit message to reflect recent changes
> * 4/4:
> - Check for the type of the packet before doing further investigation
> in TSO
>
> Michal Krawczyk (4):
> net/ena: fix incorrect Rx descriptors allocation
> net/ena: fix delayed cleanup of Rx descriptors
> net/ena: cleanup if refilling of rx descriptors fails
> net/ena: calculate partial checksum if DF bit is disabled
>
> drivers/net/ena/ena_ethdev.c | 52 ++++++++++++++++++++++++++++--
> --------------
> 1 file changed, 33 insertions(+), 19 deletions(-)
>
> --
> 1.8.3.1
>
>
Reviewed-by: Jakub Palider <jpalider@gmail.com>
next prev parent reply other threads:[~2017-04-10 22:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 14:28 Marcin Wojtas
2017-04-10 14:28 ` [dpdk-dev] [PATCH v2 1/4] net/ena: fix incorrect Rx descriptors allocation Marcin Wojtas
2017-04-10 14:28 ` [dpdk-dev] [PATCH v2 2/4] net/ena: fix delayed cleanup of Rx descriptors Marcin Wojtas
2017-04-10 14:28 ` [dpdk-dev] [PATCH v2 3/4] net/ena: cleanup if refilling of rx descriptors fails Marcin Wojtas
2017-04-10 14:28 ` [dpdk-dev] [PATCH v2 4/4] net/ena: calculate partial checksum if DF bit is disabled Marcin Wojtas
2017-04-10 22:20 ` Jakub Palider [this message]
2017-04-12 11:22 ` [dpdk-dev] [PATCH v2 0/4] Ena PMD fixes Ferruh Yigit
2017-04-11 8:29 ` Jan M?dala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO-cEe=UtYoA=9PxtByeaLV_KyfhoQCQ6f2kqCs7BWZ_om06yQ@mail.gmail.com' \
--to=jpalider@gmail.com \
--cc=dev@dpdk.org \
--cc=evgenys@amazon.com \
--cc=gtzalik@amazon.com \
--cc=igorch@amazon.com \
--cc=jan.medala@outlook.com \
--cc=matua@amazon.com \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
--cc=netanel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).