From: Devyn Johnson <devyn.johnson@banduracyber.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Working Towards Making DPDK Compile with Additional Warning Flags
Date: Tue, 5 Nov 2019 15:04:16 -0600 [thread overview]
Message-ID: <CAOSQFq7z3y1ypBdWn4U01b+FJxi1TkRp+=nxHYdc2JP25sWQxg@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8wJOF=fKiXbuX8gWF49cq0irkso5Mfw=a=gPQnMGOPnxQ@mail.gmail.com>
On Tue, Nov 5, 2019 at 1:36 PM David Marchand <david.marchand@redhat.com>
wrote:
> Hello,
>
> On Tue, Nov 5, 2019 at 7:17 PM <devyn.johnson@banduracyber.com> wrote:
> >
> > From: Devyn Collier Johnson <Devyn.Johnson@BanduraCyber.com>
> >
> > Signed-off-by: Devyn Collier Johnson <Devyn.Johnson@BanduraCyber.com>
> > ---
> > lib/librte_cryptodev/rte_cryptodev.c | 4 ++--
> > lib/librte_eal/common/eal_common_cpuflags.c | 4 ++--
> > lib/librte_eal/common/eal_common_errno.c | 2 +-
> > lib/librte_eal/common/eal_common_hexdump.c | 4 ++--
> > lib/librte_eal/common/eal_common_lcore.c | 10 +++++-----
> > lib/librte_eal/common/eal_common_log.c | 10 +++++-----
> > lib/librte_eal/common/eal_common_memalloc.c | 8 ++++----
> > lib/librte_eal/common/eal_common_memory.c | 2 +-
> > lib/librte_eal/common/eal_common_proc.c | 2 +-
> > lib/librte_eal/common/eal_common_tailqs.c | 2 +-
> > lib/librte_eal/common/eal_memalloc.h | 8 ++++----
> > lib/librte_eal/common/eal_private.h | 2 +-
> > lib/librte_eal/common/include/rte_bitmap.h | 20 ++++++++++----------
> > lib/librte_eal/common/include/rte_common.h | 2 +-
> > lib/librte_eal/common/include/rte_errno.h | 2 +-
> > lib/librte_eal/common/include/rte_hexdump.h | 2 +-
> > lib/librte_eal/common/include/rte_lcore.h | 10 +++++-----
> > lib/librte_eal/common/include/rte_log.h | 8 ++++----
> > lib/librte_eal/common/malloc_elem.c | 4 ++--
> > lib/librte_eal/linux/eal/eal.c | 2 +-
> > lib/librte_ethdev/rte_class_eth.c | 2 +-
> > lib/librte_ethdev/rte_mtr.c | 2 +-
> > lib/librte_ethdev/rte_tm.c | 2 +-
> > lib/librte_mbuf/rte_mbuf.c | 4 ++--
> > lib/librte_mbuf/rte_mbuf_dyn.c | 4 ++--
> > lib/librte_mempool/rte_mempool.c | 2 +-
> > lib/librte_ring/rte_ring.c | 2 +-
> > lib/librte_timer/rte_timer.c | 20 ++++++++++----------
> > 28 files changed, 73 insertions(+), 73 deletions(-)
>
> Thanks for the patch.
>
> It is missing a commitlog describing the problem that you faced, and
> explaining how this patch fixes this problem.
> It touches a lot of different parts of the dpdk, which will make it
> harder to review and (if applicable) harder to backport in stable
> branches.
>
> Before submitting new patches, please take the time to read our
> contributing guide that you can find here:
> http://doc.dpdk.org/guides/contributing/patches.html
>
>
> --
> David Marchand
>
>
These changes are merely one step toward making DPDK compile successfully
when using the compiler flags `-Werror -Wall -Wextra -Wpedantic
-Wdangling-else -Wdate-time -Wdisabled-optimization -Winit-self
-Winvalid-pch -Woverlength-strings -Wpointer-arith -Wredundant-decls
-Wshift-negative-value -Wstack-protector -Wuninitialized -Wunused-parameter
-Wunused-result`. Doing so can frequently reduce the probability of bugs
that are difficult to reproduce as well as point out situations the
developer did not intend to create. Currently, DPDK will not compile with
such flags set.
--
Thanks,
Devyn Collier Johnson
Devyn.Johnson@BanduraCyber.com
prev parent reply other threads:[~2019-11-05 21:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 18:16 devyn.johnson
2019-11-05 18:36 ` [dpdk-dev] [PATCH] Applied tweaks requested by the mailing-list patch-checker devyn.johnson
2019-11-05 18:45 ` [dpdk-dev] [PATCH] Fixed one missed request for " devyn.johnson
2019-11-05 19:35 ` [dpdk-dev] [PATCH] Working Towards Making DPDK Compile with Additional Warning Flags David Marchand
2019-11-05 21:04 ` Devyn Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOSQFq7z3y1ypBdWn4U01b+FJxi1TkRp+=nxHYdc2JP25sWQxg@mail.gmail.com' \
--to=devyn.johnson@banduracyber.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).