From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: jspewock@iol.unh.edu
Cc: Honnappa.Nagarahalli@arm.com, thomas@monjalon.net,
wathsala.vithanage@arm.com, probb@iol.unh.edu,
paul.szczepanek@arm.com, yoan.picchi@foss.arm.com,
ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru,
dev@dpdk.org
Subject: Re: [PATCH v4 5/7] dts: allow configuring MTU of ports
Date: Tue, 19 Dec 2023 17:58:34 +0100 [thread overview]
Message-ID: <CAOb5WZZh2ghKNhTNrM_Dp4UurrQSkFETsgVkGtQU9LQrSZPPiw@mail.gmail.com> (raw)
In-Reply-To: <20231218181221.10057-6-jspewock@iol.unh.edu>
On Mon, Dec 18, 2023 at 7:13 PM <jspewock@iol.unh.edu> wrote:
>
> From: Jeremy Spewock <jspewock@iol.unh.edu>
>
> Adds methods in both os_session and linux session to allow for setting
> MTU of port interfaces in an OS agnostic way.
>
The previous two commit messages had a little bit of an explanation,
but this one is missing one. Something like why a test case/suite
needs to set the MTU.
> Signed-off-by: Jeremy Spewock <jspewock@iol.unh.edu>
> ---
> dts/framework/remote_session/linux_session.py | 8 ++++++++
> dts/framework/remote_session/os_session.py | 9 +++++++++
> 2 files changed, 17 insertions(+)
>
> diff --git a/dts/framework/remote_session/linux_session.py b/dts/framework/remote_session/linux_session.py
> index fd877fbfae..aaa4d57a36 100644
> --- a/dts/framework/remote_session/linux_session.py
> +++ b/dts/framework/remote_session/linux_session.py
> @@ -177,6 +177,14 @@ def configure_port_ip_address(
> verify=True,
> )
>
> + def configure_port_mtu(self, mtu: int, port: Port) -> None:
> + """Overrides :meth:`~.os_session.OSSession.configure_port_mtu`."""
> + self.send_command(
> + f"ip link set dev {port.logical_name} mtu {mtu}",
> + privileged=True,
> + verify=True,
> + )
> +
> def configure_ipv4_forwarding(self, enable: bool) -> None:
> state = 1 if enable else 0
> self.send_command(f"sysctl -w net.ipv4.ip_forward={state}", privileged=True)
> diff --git a/dts/framework/remote_session/os_session.py b/dts/framework/remote_session/os_session.py
> index 8a709eac1c..cd073f5774 100644
> --- a/dts/framework/remote_session/os_session.py
> +++ b/dts/framework/remote_session/os_session.py
> @@ -277,6 +277,15 @@ def configure_port_ip_address(
> Configure (add or delete) an IP address of the input port.
> """
>
> + @abstractmethod
> + def configure_port_mtu(self, mtu: int, port: Port) -> None:
> + """Configure `mtu` on `port`.
> +
> + Args:
> + mtu: Desired MTU value.
> + port: Port to set `mtu` on.
> + """
> +
> @abstractmethod
> def configure_ipv4_forwarding(self, enable: bool) -> None:
> """
> --
> 2.43.0
>
next prev parent reply other threads:[~2023-12-19 16:58 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 18:12 [PATCH v4 0/7] dts: Port scatter suite over jspewock
2023-12-18 18:12 ` [PATCH v4 1/7] dts: add required methods to testpmd_shell jspewock
2023-12-19 16:45 ` Juraj Linkeš
2023-12-21 19:37 ` Jeremy Spewock
2024-01-03 11:10 ` Juraj Linkeš
2023-12-18 18:12 ` [PATCH v4 2/7] dts: allow passing parameters into interactive apps jspewock
2023-12-19 16:50 ` Juraj Linkeš
2023-12-18 18:12 ` [PATCH v4 3/7] dts: add optional packet filtering to scapy sniffer jspewock
2023-12-19 16:54 ` Juraj Linkeš
2023-12-18 18:12 ` [PATCH v4 4/7] dts: add pci addresses to EAL parameters jspewock
2023-12-19 16:55 ` Juraj Linkeš
2023-12-18 18:12 ` [PATCH v4 5/7] dts: allow configuring MTU of ports jspewock
2023-12-19 16:58 ` Juraj Linkeš [this message]
2023-12-18 18:12 ` [PATCH v4 6/7] dts: add scatter to the yaml schema jspewock
2023-12-19 16:59 ` Juraj Linkeš
2023-12-18 18:12 ` [PATCH v4 7/7] dts: add scatter test suite jspewock
2023-12-19 17:29 ` Juraj Linkeš
2023-12-21 21:47 ` Jeremy Spewock
2024-01-03 11:14 ` Juraj Linkeš
2024-01-03 22:12 ` [PATCH v5 0/7] dts: Port scatter suite over jspewock
2024-01-03 22:12 ` [PATCH v5 1/7] dts: add startup verification and forwarding modes to testpmd shell jspewock
2024-01-03 22:12 ` [PATCH v5 2/7] dts: limit EAL parameters to DPDK apps and add parameters to all apps jspewock
2024-01-03 22:12 ` [PATCH v5 3/7] dts: add optional packet filtering to scapy sniffer jspewock
2024-01-03 22:12 ` [PATCH v5 4/7] dts: add pci addresses to EAL parameters jspewock
2024-01-03 22:12 ` [PATCH v5 5/7] dts: allow configuring MTU of ports jspewock
2024-01-03 22:12 ` [PATCH v5 6/7] dts: add scatter to the yaml schema jspewock
2024-01-03 22:12 ` [PATCH v5 7/7] dts: add pmd_buffer_scatter test suite jspewock
2024-01-03 22:31 ` [PATCH v6 0/7] dts: Port scatter suite over jspewock
2024-01-03 22:32 ` [PATCH v6 1/7] dts: add startup verification and forwarding modes to testpmd shell jspewock
2024-01-08 11:34 ` Juraj Linkeš
2024-01-08 16:36 ` Jeremy Spewock
2024-01-09 11:54 ` Juraj Linkeš
2024-01-09 14:31 ` Jeremy Spewock
2024-01-03 22:32 ` [PATCH v6 2/7] dts: limit EAL parameters to DPDK apps and add parameters to all apps jspewock
2024-01-08 11:52 ` Juraj Linkeš
2024-01-08 16:37 ` Jeremy Spewock
2024-01-03 22:32 ` [PATCH v6 3/7] dts: add optional packet filtering to scapy sniffer jspewock
2024-01-08 12:01 ` Juraj Linkeš
2024-01-08 16:39 ` Jeremy Spewock
2024-01-08 16:40 ` Jeremy Spewock
2024-01-03 22:32 ` [PATCH v6 4/7] dts: add pci addresses to EAL parameters jspewock
2024-01-08 14:59 ` Juraj Linkeš
2024-01-03 22:32 ` [PATCH v6 5/7] dts: allow configuring MTU of ports jspewock
2024-01-08 15:00 ` Juraj Linkeš
2024-01-03 22:32 ` [PATCH v6 6/7] dts: add scatter to the yaml schema jspewock
2024-01-08 15:01 ` Juraj Linkeš
2024-01-03 22:32 ` [PATCH v6 7/7] dts: add pmd_buffer_scatter test suite jspewock
2024-01-08 15:47 ` Juraj Linkeš
2024-01-08 16:53 ` Jeremy Spewock
2024-01-09 15:36 ` [PATCH v7 0/7] dts: Port scatter suite over jspewock
2024-01-09 15:36 ` [PATCH v7 1/7] dts: add startup verification and forwarding modes to testpmd shell jspewock
2024-01-10 13:18 ` Juraj Linkeš
2024-01-10 14:09 ` Jeremy Spewock
2024-01-09 15:36 ` [PATCH v7 2/7] dts: limit EAL parameters to DPDK apps and add parameters to all apps jspewock
2024-01-09 15:36 ` [PATCH v7 3/7] dts: add optional packet filtering to scapy sniffer jspewock
2024-01-09 15:36 ` [PATCH v7 4/7] dts: add pci addresses to EAL parameters jspewock
2024-01-09 15:36 ` [PATCH v7 5/7] dts: allow configuring MTU of ports jspewock
2024-01-09 15:36 ` [PATCH v7 6/7] dts: add scatter to the yaml schema jspewock
2024-01-09 15:36 ` [PATCH v7 7/7] dts: add pmd_buffer_scatter test suite jspewock
2024-01-10 13:16 ` Juraj Linkeš
2024-01-10 14:09 ` Jeremy Spewock
2024-01-10 13:22 ` [PATCH v7 0/7] dts: Port scatter suite over Juraj Linkeš
2024-01-10 14:42 ` [PATCH v8 " jspewock
2024-01-10 14:42 ` [PATCH v8 1/7] dts: add startup verification and forwarding modes to testpmd shell jspewock
2024-01-10 14:42 ` [PATCH v8 2/7] dts: limit EAL parameters to DPDK apps and add parameters to all apps jspewock
2024-01-10 14:42 ` [PATCH v8 3/7] dts: add optional packet filtering to scapy sniffer jspewock
2024-01-10 14:42 ` [PATCH v8 4/7] dts: add pci addresses to EAL parameters jspewock
2024-01-10 14:42 ` [PATCH v8 5/7] dts: allow configuring MTU of ports jspewock
2024-01-10 14:42 ` [PATCH v8 6/7] dts: add scatter to the yaml schema jspewock
2024-01-10 14:42 ` [PATCH v8 7/7] dts: add pmd_buffer_scatter test suite jspewock
2024-01-11 10:07 ` [PATCH v8 0/7] dts: Port scatter suite over Juraj Linkeš
2024-02-21 3:34 ` Patrick Robb
2024-03-07 15:00 ` Thomas Monjalon
2024-03-11 14:15 ` Jeremy Spewock
2024-03-11 15:43 ` [PATCH v9 " jspewock
2024-03-11 15:43 ` [PATCH v9 1/7] dts: add startup verification and forwarding modes to testpmd shell jspewock
2024-03-11 15:44 ` [PATCH v9 2/7] dts: limit EAL parameters to DPDK apps and add parameters to all apps jspewock
2024-03-11 15:44 ` [PATCH v9 3/7] dts: add optional packet filtering to scapy sniffer jspewock
2024-03-11 15:44 ` [PATCH v9 4/7] dts: add pci addresses to EAL parameters jspewock
2024-03-11 15:44 ` [PATCH v9 5/7] dts: allow configuring MTU of ports jspewock
2024-03-11 15:44 ` [PATCH v9 6/7] dts: add scatter to the yaml schema jspewock
2024-03-11 15:44 ` [PATCH v9 7/7] dts: add pmd_buffer_scatter test suite jspewock
2024-03-15 17:41 ` [PATCH v9 0/7] dts: Port scatter suite over Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2023-11-13 20:28 [PATCH v3 " jspewock
2023-12-14 22:10 ` [PATCH v4 5/7] dts: allow configuring MTU of ports jspewock
2023-12-18 17:22 ` jspewock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOb5WZZh2ghKNhTNrM_Dp4UurrQSkFETsgVkGtQU9LQrSZPPiw@mail.gmail.com \
--to=juraj.linkes@pantheon.tech \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=jspewock@iol.unh.edu \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=thomas@monjalon.net \
--cc=wathsala.vithanage@arm.com \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).