From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: Nicholas Pratte <npratte@iol.unh.edu>
Cc: paul.szczepanek@arm.com, wathsala.vithanage@arm.com,
bruce.richardson@intel.com, yoan.picchi@foss.arm.com,
mb@smartsharesystems.com, jspewock@iol.unh.edu,
Honnappa.Nagarahalli@arm.com, thomas@monjalon.net,
probb@iol.unh.edu, dev@dpdk.org
Subject: Re: [PATCH v3] dts: Change hugepage runtime config to 2MB Exclusively
Date: Wed, 17 Apr 2024 15:46:03 +0200 [thread overview]
Message-ID: <CAOb5WZbG8sv4oFSHAOXiPFftcDmnaZ-PBC9VXF-YZNJ5JdX=DQ@mail.gmail.com> (raw)
In-Reply-To: <20240416181840.11539-1-npratte@iol.unh.edu>
Don't forget to run the ../devtools/dts-check-format.sh script, it
found one issue:
framework/testbed_model/os_session.py:351: [D] D417 Missing argument
descriptions in the docstring [pydocstyle]
On Tue, Apr 16, 2024 at 8:18 PM Nicholas Pratte <npratte@iol.unh.edu> wrote:
>
> The previous implementation configures and allocates hugepage sizes
> based on a system default. This can lead to two problems: overallocation of
> hugepages (which may crash the remote host), and configuration of hugepage
> sizes that are not recommended during runtime. This new implementation
> allows only 2MB hugepage allocation during runtime; any other unique
> hugepage size must be configured by the end-user for initializing DTS.
>
> If the amount of 2MB hugepages requested exceeds the amount of 2MB
> hugepages already configured on the system, then the system will remount
> hugepages to cover the difference. If the amount of hugepages requested is
> either less than or equal to the amount already configured on the system,
> then nothing is done.
>
> Bugzilla ID: 1370
> Signed-off-by: Nicholas Pratte <npratte@iol.unh.edu>
> Reviewed-by: Jeremy Spewock <jspewock@iol.unh.edu>
> ---
> doc/guides/tools/dts.rst | 7 +++++-
> dts/conf.yaml | 4 ++--
> dts/framework/config/__init__.py | 4 ++--
> dts/framework/config/conf_yaml_schema.json | 6 ++---
> dts/framework/config/types.py | 2 +-
> dts/framework/testbed_model/linux_session.py | 24 +++++++++++---------
> dts/framework/testbed_model/node.py | 8 ++++++-
> dts/framework/testbed_model/os_session.py | 4 +++-
> 8 files changed, 37 insertions(+), 22 deletions(-)
>
> diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools/dts.rst
> index 47b218b2c6..1103db0faa 100644
> --- a/doc/guides/tools/dts.rst
> +++ b/doc/guides/tools/dts.rst
> @@ -131,7 +131,12 @@ There are two areas that need to be set up on a System Under Test:
>
> You may specify the optional hugepage configuration in the DTS config file.
> If you do, DTS will take care of configuring hugepages,
> - overwriting your current SUT hugepage configuration.
> + overwriting your current SUT hugepage configuration. Configuration of hugepages via DTS
> + allows only for configuration of 2MB hugepages.
I'd like to see a quick explanation of why we only do 2MB hugepages,
like you mentioned in the commit message.
> Thus, if your needs require hugepage
> + sizes not equal to 2MB, then you these configurations must be done outside of the DTS
typo - you is extra. And I think this should be configuration singular
- this configuration must be done.
> + framework; moreover, if you do not desire the use of 2MB hugepages, and instead perfer
prefer
> + other sizes (e.g 1GB), then we assume that hugepages have been manually configued before
configured
> + runtime.
Looks like the two sentences (separated by semicolon) are saying the same thing.
>
> * System under test configuration
>
next prev parent reply other threads:[~2024-04-17 13:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 15:31 [PATCH] " Nicholas Pratte
2024-04-05 14:27 ` Patrick Robb
2024-04-06 8:47 ` Morten Brørup
2024-04-06 19:20 ` Patrick Robb
2024-04-06 22:04 ` Morten Brørup
2024-04-08 8:10 ` Bruce Richardson
2024-04-08 9:35 ` Morten Brørup
2024-04-09 16:57 ` Nicholas Pratte
2024-04-09 17:28 ` [PATCH v2] " Nicholas Pratte
2024-04-10 7:23 ` Morten Brørup
2024-04-10 13:50 ` Patrick Robb
2024-04-10 10:43 ` Juraj Linkeš
2024-04-16 18:18 ` [PATCH v3] " Nicholas Pratte
2024-04-16 18:25 ` Morten Brørup
2024-04-16 18:26 ` Nicholas Pratte
2024-04-17 13:46 ` Juraj Linkeš [this message]
2024-04-18 16:10 ` [PATCH v4] " Nicholas Pratte
2024-04-25 8:00 ` Juraj Linkeš
2024-04-29 17:26 ` Nicholas Pratte
2024-04-30 8:42 ` Juraj Linkeš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOb5WZbG8sv4oFSHAOXiPFftcDmnaZ-PBC9VXF-YZNJ5JdX=DQ@mail.gmail.com' \
--to=juraj.linkes@pantheon.tech \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jspewock@iol.unh.edu \
--cc=mb@smartsharesystems.com \
--cc=npratte@iol.unh.edu \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=thomas@monjalon.net \
--cc=wathsala.vithanage@arm.com \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).