From: alan somers <asomers@gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Fix bash path in shebangs
Date: Wed, 13 Sep 2017 09:55:40 -0600 [thread overview]
Message-ID: <CAOtMX2go--gPKb45NtJ+ww9uvM54t97NOh6OrdBb0ypQV_G71w@mail.gmail.com> (raw)
In-Reply-To: <1950575.vEqoHlsAsr@xps>
On Wed, Sep 13, 2017 at 9:39 AM, Thomas Monjalon <thomas@monjalon.net> wrote:
> 13/09/2017 16:35, alan somers:
>> On Wed, Sep 13, 2017 at 3:37 AM, Thomas Monjalon <thomas@monjalon.net> wrote:
>> > 27/07/2017 22:12, asomers@gmail.com:
>> >> From: Alan Somers <asomers@gmail.com>
>> >>
>> >> "/bin/bash" is a Linuxism. "/usr/bin/env bash" is portable.
>> >
>> > Why is it an issue?
>> >
>> > Can you run dpdk-setup.sh on a non-Linux system?
>>
>> Nope, because even dpdk-setup.sh assumes that bash is located at
>> /bin/bash. But "/usr/bin/env bash" works everywhere.
>
> No, I mean: can you run dpdk-setup.sh on a non-Linux system after your change?
>
> This script configures a Linux system, so I want to understand
> what situation you are trying to fix.
I'm using Ceph, which imports DPDK whole (and several other 3rd party
projects too). I'm not sure which parts of these 3rd party projects
Ceph is actually using, but it's easier to fix the bash path
everywhere than to determine which places need it to be fixed. And
AFAIK it doesn't cause any problems on any modern Unix derivative.
-Alan
next prev parent reply other threads:[~2017-09-13 15:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 20:12 asomers
2017-09-13 9:37 ` Thomas Monjalon
2017-09-13 14:35 ` alan somers
2017-09-13 15:39 ` Thomas Monjalon
2017-09-13 15:55 ` alan somers [this message]
2017-09-13 16:51 ` Thomas Monjalon
2017-07-27 20:41 asomers
2017-07-28 9:28 ` Bruce Richardson
2017-07-31 15:11 ` alan somers
2017-07-31 15:22 ` Bruce Richardson
2017-07-31 16:18 ` alan somers
2017-07-31 17:06 ` Wiles, Keith
2017-07-31 19:08 ` alan somers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOtMX2go--gPKb45NtJ+ww9uvM54t97NOh6OrdBb0ypQV_G71w@mail.gmail.com \
--to=asomers@gmail.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).