From: Andriy Berestovskyy <aber@semihalf.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Horton, Remy" <remy.horton@intel.com>
Subject: Re: [dpdk-dev] [PATCH] keepalive: fix keepalive state alignment
Date: Mon, 22 Jan 2018 19:20:32 +0100 [thread overview]
Message-ID: <CAOysbxoRFMfn2W-ekdtSQ-3xkLwLANt-E4WWupihUh1gwR+TKQ@mail.gmail.com> (raw)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA650FF2A1C@IRSMSX102.ger.corp.intel.com>
Hey Harry,
Thanks for the review.
On Fri, Jan 19, 2018 at 6:31 PM, Van Haaren, Harry
<harry.van.haaren@intel.com> wrote:
> These changes do reduce false-sharing however is there actually a performance benefit? A lot of cache space will be taken up if each core requires its own cache line, which will reduce performance again.. it's a tradeoff.
1. False sharing is happening in the data path vs loops in control paths.
2. The original code (prior e70a61ad50ab "keepalive: export states")
had each element aligned to the cache line, not the whole array.
> Little fix for a v2: "s" is not a good variable name for the rte_keepalive_state, please use something more descriptive.
Sure, if there are no more comments, I'll change it.
Andriy
next prev parent reply other threads:[~2018-01-22 18:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 14:47 Andriy Berestovskyy
2018-01-19 17:31 ` Van Haaren, Harry
2018-01-22 18:20 ` Andriy Berestovskyy [this message]
2018-01-23 10:16 ` Remy Horton
2018-01-23 10:27 ` Van Haaren, Harry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOysbxoRFMfn2W-ekdtSQ-3xkLwLANt-E4WWupihUh1gwR+TKQ@mail.gmail.com \
--to=aber@semihalf.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=remy.horton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).