From: Ronak Doshi <ronak.doshi@broadcom.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: Jochen Behrens <jbehrens@vmware.com>,
Ronak Doshi <doshir@vmware.com>,
dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH v2] net/vmxnet3: fix a missing vmxnet3 register command
Date: Mon, 22 Apr 2024 10:48:21 -0700 [thread overview]
Message-ID: <CAP1Q3XS=enPh02PKib9eFCEHBnYsRN3jJ73sj4dNWOM_OiPYZw@mail.gmail.com> (raw)
In-Reply-To: <8530ecbc-dafc-412b-aba4-553eeacbebdc@amd.com>
[-- Attachment #1: Type: text/plain, Size: 2861 bytes --]
Basically it will just provide incorrect information. With the enum being
misaligned due to missing command, GET_DCR0_REG and GET_MAX_CAPABILITIES
will just lead to incorrect commands being issued.
Thanks,
Ronak
On Fri, Apr 19, 2024 at 1:35 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote:
> On 4/18/2024 7:36 AM, Ronak Doshi wrote:
> > Vmxnet3 uses capability registers to advertise the supported
> > capabilities of UPT device. It uses DCR0_REG command register
> > for this purpose. However, the register command enum misses
> > one command which technically is not used by dpdk vmxnet3
> > driver yet. This can cause issue for commands added later.
> >
> > This patch fixes this issue by adding a reserved
> > command in its place.
> >
> > Fixes: 5241d61bd865 ("net/vmxnet3: support capability registers")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ronak Doshi <ronak.doshi@broadcom.com>
> > --
> > Change log
> > v2: fixed typo
> > ---
> > drivers/net/vmxnet3/base/vmxnet3_defs.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/vmxnet3/base/vmxnet3_defs.h
> b/drivers/net/vmxnet3/base/vmxnet3_defs.h
> > index 24c235876e..a6bb281d8d 100644
> > --- a/drivers/net/vmxnet3/base/vmxnet3_defs.h
> > +++ b/drivers/net/vmxnet3/base/vmxnet3_defs.h
> > @@ -126,6 +126,7 @@ typedef enum {
> > VMXNET3_CMD_RESERVED7,
> > VMXNET3_CMD_RESERVED8,
> > VMXNET3_CMD_GET_MAX_QUEUES_CONF,
> > + VMXNET3_CMD_RESERVED11,
> > VMXNET3_CMD_GET_MAX_CAPABILITIES,
> > VMXNET3_CMD_GET_DCR0_REG,
> > } Vmxnet3_Cmd;
>
> Hi Ronak,
>
> Thank you for the patch.
>
> What is the fixed from user perspective, what is the impact.
>
> I can see two commands effected from missing enum, they are GET_DCR0_REG
> & GET_MAX_CAPABILITIES.
> Was user not able to read capabilities, or get random capabilities, from
> device up until now?
> If so what were these capabilities and how user impacted from missing them?
> Can you please detail the impact more in the commit log?
>
>
>
--
This electronic communication and the information and any files transmitted
with it, or attached to it, are confidential and are intended solely for
the use of the individual or entity to whom it is addressed and may contain
information that is confidential, legally privileged, protected by privacy
laws, or otherwise restricted from disclosure to anyone else. If you are
not the intended recipient or the person responsible for delivering the
e-mail to the intended recipient, you are hereby notified that any use,
copying, distributing, dissemination, forwarding, printing, or copying of
this e-mail is strictly prohibited. If you received this e-mail in error,
please return the e-mail to the sender, delete it from your computer, and
destroy any printed copy of it.
[-- Attachment #2: Type: text/html, Size: 3787 bytes --]
prev parent reply other threads:[~2024-04-22 17:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 6:36 Ronak Doshi
2024-04-19 8:35 ` Ferruh Yigit
2024-04-22 17:48 ` Ronak Doshi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP1Q3XS=enPh02PKib9eFCEHBnYsRN3jJ73sj4dNWOM_OiPYZw@mail.gmail.com' \
--to=ronak.doshi@broadcom.com \
--cc=dev@dpdk.org \
--cc=doshir@vmware.com \
--cc=ferruh.yigit@amd.com \
--cc=jbehrens@vmware.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).