From: Jianbo Liu <jianbo.liu@linaro.org>
To: Phil Yang <phil.yang@arm.com>
Cc: dev@dpdk.org, nd@arm.com, Herbert Guan <Herbert.Guan@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix stats period can't quit normally in container
Date: Fri, 22 Sep 2017 18:32:22 +0800 [thread overview]
Message-ID: <CAP4Qi3_jsKv6i+TqH=QZ7RY5nCp0CYuvyc+yuT3SJXJHWaVcYw@mail.gmail.com> (raw)
In-Reply-To: <1506061292-2814-1-git-send-email-phil.yang@arm.com>
On 22 September 2017 at 14:21, Phil Yang <phil.yang@arm.com> wrote:
> In container, the process cannot be terminated by SIGINT/SIGTERM when
> execute with 'stats-period' option.
> Fixed by adding a flag to exit stats period loop after received either
> SIGINT or SIGTERM.
>
> Signed-off-by: Phil Yang <phil.yang@arm.com>
> ---
> app/test-pmd/testpmd.c | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index e097ee0..3ccc9ba 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -183,6 +183,13 @@ uint16_t mbuf_data_size = DEFAULT_MBUF_DATA_SIZE; /**< Mbuf data space size. */
> uint32_t param_total_num_mbufs = 0; /**< number of mbufs in all pools - if
> * specified on command-line. */
> uint16_t stats_period; /**< Period to show statistics (disabled by default) */
> +
> +/*
> + * In container, it cannot terminate the process which running with 'stats-period'
> + * option. Set flag to exit stats period loop after received SIGINT/SIGTERM.
> + */
> +uint8_t f_quit;
> +
> /*
> * Configuration of packet segments used by the "txonly" processing engine.
> */
> @@ -2318,6 +2325,8 @@ signal_handler(int signum)
> rte_latencystats_uninit();
> #endif
> force_quit();
> + /* Set flag to indicate the force termination. */
> + f_quit = 1;
> /* exit with the expected status */
> signal(signum, SIG_DFL);
> kill(getpid(), signum);
> @@ -2435,6 +2444,8 @@ main(int argc, char** argv)
> char c;
> int rc;
>
> + f_quit = 0;
> +
> printf("No commandline core given, start packet forwarding\n");
> start_packet_forwarding(tx_first);
> if (stats_period != 0) {
> @@ -2444,7 +2455,7 @@ main(int argc, char** argv)
> /* Convert to number of cycles */
> timer_period = stats_period * rte_get_timer_hz();
>
> - while (1) {
> + while (f_quit == 0) {
> cur_time = rte_get_timer_cycles();
> diff_time += cur_time - prev_time;
>
> --
> 2.7.4
>
Acked-by: Jianbo Liu <jianbo.liu@linaro.org>
next prev parent reply other threads:[~2017-09-22 10:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 3:40 [dpdk-dev] [PATCH] " Phil Yang
2017-09-21 8:32 ` Jianbo Liu
2017-09-22 6:12 ` [dpdk-dev] [PATCH v2] " Phil Yang
2017-09-22 6:21 ` Phil Yang
2017-09-22 10:32 ` Jianbo Liu [this message]
2017-10-09 5:27 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP4Qi3_jsKv6i+TqH=QZ7RY5nCp0CYuvyc+yuT3SJXJHWaVcYw@mail.gmail.com' \
--to=jianbo.liu@linaro.org \
--cc=Herbert.Guan@arm.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=phil.yang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).