From: "Wiles, Keith" <keith.wiles@intel.com>
To: Luca Boccassi <bluca@debian.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 1/3] dfs:add FUSE based filesystem for DPDK
Date: Mon, 17 Dec 2018 16:26:36 +0000 [thread overview]
Message-ID: <CCBF4A4E-A1E5-43B7-B234-DAA8734CB888@intel.com> (raw)
In-Reply-To: <1544998977.4766.10.camel@debian.org>
> On Dec 16, 2018, at 4:22 PM, Luca Boccassi <bluca@debian.org> wrote:
>
> On Sun, 2018-12-16 at 11:46 -0600, Keith Wiles wrote:
>> --- /dev/null
>> +++ b/lib/librte_dfs/meson.build
>> @@ -0,0 +1,47 @@
>> +# SPDX-License-Identifier: BSD-3-Clause
>> +# Copyright(c) 2018 Intel Corporation
>> +
>> +version = 1
>
> You can leave the version out if it's 1, it's the default
I understand that maybe the default, but it should not hurt anything and then the developer can update it as needed, right?
>
>> --- /dev/null
>> +++ b/lib/librte_dfs/Makefile
>> @@ -0,0 +1,51 @@
>> +# SPDX-License-Identifier: BSD-3-Clause
>> +# Copyright(c) 2018 Intel Corporation
>> +
>> +include $(RTE_SDK)/mk/rte.vars.mk
>> +
>> +# library name
>> +LIB = librte_dfs.a
>> +
>> +CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) -O3
>> +CFLAGS += -DALLOW_EXPERIMENTAL_API -D_FILE_OFFSET_BITS=64
>> +CFLAGS += -D_GNU_SOURCE
>> +CFLAGS += -I$(RTE_SDK)/drivers/bus/pci
>> +LDLIBS += -lrte_eal -lrte_mempool -lrte_hash -lrte_ethdev
>> -lrte_utils
>> +LDLIBS += -lrte_ring -lrte_timer -lrte_rawdev -lrte_cryptodev
>> +LDLIBS += -lpthread
>> +LDLIBS += $(shell pkg-config --libs-only-l fuse3)
>> +LDLIBS += $(shell pkg-config --libs-only-l jansson)
>
> Why --libs-only-l ? If the libraries are not installed in the canonical
> path (eg: build-root-without-chroot) it will break as it won't use the
> -L
OK, will look at this one and see if I had a reason to use libs-only-l.
>
> --
> Kind regards,
> Luca Boccassi
Regards,
Keith
next prev parent reply other threads:[~2018-12-17 16:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-16 17:46 Keith Wiles
2018-12-16 22:22 ` Luca Boccassi
2018-12-17 16:26 ` Wiles, Keith [this message]
2018-12-17 19:02 ` Luca Boccassi
2018-12-17 11:45 ` Thomas Monjalon
2018-12-17 15:01 ` Wiles, Keith
2018-12-17 16:12 ` Thomas Monjalon
2018-12-19 17:38 ` Wiles, Keith
2023-06-09 17:04 ` [PATCH v4] " Stephen Hemminger
2018-12-27 18:16 ` [dpdk-dev] " Keith Wiles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CCBF4A4E-A1E5-43B7-B234-DAA8734CB888@intel.com \
--to=keith.wiles@intel.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).