From: rongwei liu <rongweil@nvidia.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>,
"dev@dpdk.org" <dev@dpdk.org>, Matan Azrad <matan@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Ori Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
Raslan Darawsheh <rasland@nvidia.com>
Cc: Michael Baum <michaelba@nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>
Subject: Re: [PATCH v1 1/2] app/testpmd: fix modify tag typo
Date: Thu, 22 Feb 2024 03:06:33 +0000 [thread overview]
Message-ID: <CH3PR12MB8209D421B8529F37C9352E17AB562@CH3PR12MB8209.namprd12.prod.outlook.com> (raw)
In-Reply-To: <787e4cc7-8687-482e-b59e-4826e6ae87d3@amd.com>
[-- Attachment #1: Type: text/plain, Size: 2162 bytes --]
I am using the master-net-mlx branch as base to verify.
And cross-checked the main and master-net-mlx branch diverage now.
Patch 1 was good and patch 2 failed to apply on the main branch.
[rongweil@gen-l-vrt-290 mlnx_dpdk]$ patch -d ./ -p 1 < 1.patch
patching file app/test-pmd/cmdline_flow.c
Hunk #1 succeeded at 7283 (offset -186 lines).
[rongweil@gen-l-vrt-290 mlnx_dpdk]$ patch -d ./ -p 1 < 2.patch
patching file drivers/net/mlx5/mlx5_flow.c
Hunk #1 succeeded at 2384 with fuzz 1 (offset 15 lines).
patching file drivers/net/mlx5/mlx5_flow_hw.c
Hunk #1 FAILED at 6104.
Hunk #2 FAILED at 6129.
2 out of 2 hunks FAILED -- saving rejects to file drivers/net/mlx5/mlx5_flow_hw.c.rej
@Raslan Darawsheh<mailto:rasland@nvidia.com>Do I need to switch to main branch when sending patches to community?
BR
Rongwei
________________________________
From: Ferruh Yigit <ferruh.yigit@amd.com>
Sent: Thursday, February 22, 2024 0:42
To: rongwei liu <rongweil@nvidia.com>; dev@dpdk.org <dev@dpdk.org>; Matan Azrad <matan@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>
Cc: Michael Baum <michaelba@nvidia.com>; stable@dpdk.org <stable@dpdk.org>; Dariusz Sosnowski <dsosnowski@nvidia.com>; Aman Singh <aman.deep.singh@intel.com>; Yuying Zhang <yuying.zhang@intel.com>
Subject: Re: [PATCH v1 1/2] app/testpmd: fix modify tag typo
External email: Use caution opening links or attachments
On 2/21/2024 4:33 PM, Ferruh Yigit wrote:
> On 2/21/2024 7:10 AM, Rongwei Liu wrote:
>> Update the name to the right one: "src_tag_index"
>>
>> Fixes: 7ea38955b ("ethdev: update MPLS header modification API")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
>> Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
>
btw, fixes commit is wrong, it should be [1], I guess this is related to
the tree you are using as other patch has similar issue.
[1]
Fixes: c23626f27b09 ("ethdev: add MPLS header modification")
[-- Attachment #2: Type: text/html, Size: 6576 bytes --]
next prev parent reply other threads:[~2024-02-22 3:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240221071043.3309205-1-rongweil@nvidia.com>
2024-02-21 7:10 ` Rongwei Liu
2024-02-21 16:33 ` Ferruh Yigit
2024-02-21 16:42 ` Ferruh Yigit
2024-02-22 3:06 ` rongwei liu [this message]
2024-02-21 7:10 ` [PATCH v1 2/2] net/mlx5: fix modify flex item error Rongwei Liu
2024-02-21 16:35 ` Ferruh Yigit
[not found] ` <20240223032155.182162-1-rongweil@nvidia.com>
2024-02-23 3:21 ` [PATCH v2 1/2] app/testpmd: fix modify tag typo Rongwei Liu
2024-02-23 12:06 ` Ferruh Yigit
2024-02-23 3:21 ` [PATCH v2 2/2] net/mlx5: fix modify flex item error Rongwei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH3PR12MB8209D421B8529F37C9352E17AB562@CH3PR12MB8209.namprd12.prod.outlook.com \
--to=rongweil@nvidia.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=ferruh.yigit@amd.com \
--cc=matan@nvidia.com \
--cc=michaelba@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).