From: "Li, Miao" <miao.li@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Hunt, David" <david.hunt@intel.com>
Cc: "Xia, Chenbo" <chenbo.xia@intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH v7 4/5] power: modify return of queue_stopped
Date: Fri, 22 Oct 2021 09:05:07 +0000 [thread overview]
Message-ID: <CO1PR11MB4900BC0011100E24F0889636EE809@CO1PR11MB4900.namprd11.prod.outlook.com> (raw)
In-Reply-To: <909815e4-2eb3-5c11-7f77-314cc3e02ccd@intel.com>
Hi,
> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Friday, October 22, 2021 5:01 PM
> To: Li, Miao <miao.li@intel.com>; dev@dpdk.org; Hunt, David
> <david.hunt@intel.com>
> Cc: Xia, Chenbo <chenbo.xia@intel.com>; maxime.coquelin@redhat.com;
> Burakov, Anatoly <anatoly.burakov@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v7 4/5] power: modify return of queue_stopped
>
> On 10/22/2021 9:20 AM, Li, Miao wrote:
> > Hi,
> >
> >> -----Original Message-----
> >> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> >> Sent: Friday, October 22, 2021 12:48 AM
> >> To: Li, Miao <miao.li@intel.com>; dev@dpdk.org; Hunt, David
> >> <david.hunt@intel.com>
> >> Cc: Xia, Chenbo <chenbo.xia@intel.com>; maxime.coquelin@redhat.com;
> >> Burakov, Anatoly <anatoly.burakov@intel.com>
> >> Subject: Re: [dpdk-dev] [PATCH v7 4/5] power: modify return of
> queue_stopped
> >>
> >> On 10/18/2021 3:16 PM, Miao Li wrote:
> >>> Since some vdevs like virtio and vhost do not support rxq_info_get and
> >>> queue state inquiry, the error return value -ENOTSUP need to be ignored
> >>> when queue_stopped cannot get rx queue information and rx queue state.
> >>> This patch changes the return value of queue_stopped when
> >>> rte_eth_rx_queue_info_get return -ENOTSUP to support vdevs which
> cannot
> >>> provide rx queue information and rx queue state enable power management.
> >>>
> >>
> >> Don't we want to backport this patch? In case later a patch in the main
> >> repo relies on this return type and that needs to be merged to LTS...
> >>
> >> Also need to clarify if this is a fix or not.
> >
> > Yes, it is a fix. I will backport this patch to LTS in the next version.
> >
>
> If so can you please update the Fixes and stable tags?
>
> This way it will be part of backporting process.
I will update them in the next version.
Thanks,
Miao
>
> > Thanks,
> > Miao
> >
> >>
> >>> Signed-off-by: Miao Li <miao.li@intel.com>
> >>> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
> >>> Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
> >>
> >> power library maintainer ack/review is missing.
> >>
> >>> ---
> >>> lib/power/rte_power_pmd_mgmt.c | 9 +++++++--
> >>> 1 file changed, 7 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/lib/power/rte_power_pmd_mgmt.c
> >> b/lib/power/rte_power_pmd_mgmt.c
> >>> index 0ce40f0875..39a2b4cd23 100644
> >>> --- a/lib/power/rte_power_pmd_mgmt.c
> >>> +++ b/lib/power/rte_power_pmd_mgmt.c
> >>> @@ -382,8 +382,13 @@ queue_stopped(const uint16_t port_id, const
> >> uint16_t queue_id)
> >>> {
> >>> struct rte_eth_rxq_info qinfo;
> >>>
> >>> - if (rte_eth_rx_queue_info_get(port_id, queue_id, &qinfo) < 0)
> >>> - return -1;
> >>> + int ret = rte_eth_rx_queue_info_get(port_id, queue_id, &qinfo);
> >>> + if (ret < 0) {
> >>> + if (ret == -ENOTSUP)
> >>> + return 1;
> >>> + else
> >>> + return -1;
> >>> + }
> >>>
> >>> return qinfo.queue_state == RTE_ETH_QUEUE_STATE_STOPPED;
> >>> }
> >>>
> >
next prev parent reply other threads:[~2021-10-22 9:05 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 13:05 [dpdk-dev] [PATCH 0/5] CPU Enabling: Implement rte_power_monitor API in virtio/vhost PMD Miao Li
2021-09-10 13:05 ` [dpdk-dev] [PATCH 1/5] net/virtio: implement rte_power_monitor API Miao Li
2021-09-15 8:45 ` Xia, Chenbo
2021-09-17 6:40 ` Li, Miao
2021-09-10 13:05 ` [dpdk-dev] [PATCH 2/5] lib/vhost: " Miao Li
2021-09-15 8:51 ` Xia, Chenbo
2021-09-17 6:51 ` Li, Miao
2021-09-10 13:05 ` [dpdk-dev] [PATCH 3/5] net/vhost: " Miao Li
2021-09-10 13:05 ` [dpdk-dev] [PATCH 4/5] lib/power: modify return of queue_stopped Miao Li
2021-09-10 13:15 ` Burakov, Anatoly
2021-09-10 13:05 ` [dpdk-dev] [PATCH 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-09-10 7:24 ` Maxime Coquelin
2021-09-10 8:33 ` Li, Miao
2021-09-10 8:50 ` David Marchand
2021-09-13 1:41 ` Li, Miao
2021-09-18 13:22 ` [dpdk-dev] [PATCH 0/5] Implement rte_power_monitor API in virtio/vhost PMD Miao Li
2021-09-18 13:22 ` [dpdk-dev] [PATCH 1/5] net/virtio: implement rte_power_monitor API Miao Li
2021-09-18 13:22 ` [dpdk-dev] [PATCH 2/5] vhost: " Miao Li
2021-09-18 13:22 ` [dpdk-dev] [PATCH 3/5] net/vhost: " Miao Li
2021-09-18 13:22 ` [dpdk-dev] [PATCH 4/5] power: modify return of queue_stopped Miao Li
2021-09-18 13:22 ` [dpdk-dev] [PATCH 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-09-24 10:23 ` [dpdk-dev] [PATCH v3 0/5] Implement rte_power_monitor API in virtio/vhost PMD Miao Li
2021-09-24 10:23 ` [dpdk-dev] [PATCH v3 1/5] net/virtio: implement rte_power_monitor API Miao Li
2021-09-29 2:34 ` Xia, Chenbo
2021-09-24 10:23 ` [dpdk-dev] [PATCH v3 2/5] vhost: " Miao Li
2021-09-29 3:01 ` Xia, Chenbo
2021-10-11 5:16 ` Li, Miao
2021-09-24 10:23 ` [dpdk-dev] [PATCH v3 3/5] net/vhost: " Miao Li
2021-09-24 10:23 ` [dpdk-dev] [PATCH v3 4/5] power: modify return of queue_stopped Miao Li
2021-09-29 3:03 ` Xia, Chenbo
2021-10-11 5:18 ` Li, Miao
2021-09-24 10:23 ` [dpdk-dev] [PATCH v3 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-09-29 6:53 ` Xia, Chenbo
2021-10-11 5:22 ` Li, Miao
2021-10-12 14:22 ` [dpdk-dev] [PATCH v4 0/5] Implement rte_power_monitor API in virtio/vhost PMD Miao Li
2021-10-12 14:22 ` [dpdk-dev] [PATCH v4 1/5] net/virtio: implement rte_power_monitor API Miao Li
2021-10-12 14:22 ` [dpdk-dev] [PATCH v4 2/5] vhost: " Miao Li
2021-10-12 14:22 ` [dpdk-dev] [PATCH v4 3/5] net/vhost: " Miao Li
2021-10-12 14:22 ` [dpdk-dev] [PATCH v4 4/5] power: modify return of queue_stopped Miao Li
2021-10-12 14:22 ` [dpdk-dev] [PATCH v4 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-10-15 15:12 ` [dpdk-dev] [PATCH v5 0/5] Implement rte_power_monitor API in virtio/vhost PMD Miao Li
2021-10-15 15:12 ` [dpdk-dev] [PATCH v5 1/5] net/virtio: implement rte_power_monitor API Miao Li
2021-10-15 15:12 ` [dpdk-dev] [PATCH v5 2/5] vhost: " Miao Li
2021-10-15 7:38 ` Xia, Chenbo
2021-10-15 8:47 ` Li, Miao
2021-10-15 15:12 ` [dpdk-dev] [PATCH v5 3/5] net/vhost: " Miao Li
2021-10-15 7:39 ` Xia, Chenbo
2021-10-15 8:49 ` Li, Miao
2021-10-15 15:12 ` [dpdk-dev] [PATCH v5 4/5] power: modify return of queue_stopped Miao Li
2021-10-15 7:47 ` Xia, Chenbo
2021-10-15 8:50 ` Li, Miao
2021-10-15 15:12 ` [dpdk-dev] [PATCH v5 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-10-15 8:13 ` Xia, Chenbo
2021-10-15 8:51 ` Li, Miao
2021-10-15 17:09 ` [dpdk-dev] [PATCH v6 0/5] Implement rte_power_monitor API in virtio/vhost PMD Miao Li
2021-10-15 12:57 ` Maxime Coquelin
2021-10-18 1:54 ` Li, Miao
2021-10-15 17:09 ` [dpdk-dev] [PATCH v6 1/5] net/virtio: implement rte_power_monitor API Miao Li
2021-10-15 17:09 ` [dpdk-dev] [PATCH v6 2/5] vhost: " Miao Li
2021-10-15 17:09 ` [dpdk-dev] [PATCH v6 3/5] net/vhost: " Miao Li
2021-10-15 17:09 ` [dpdk-dev] [PATCH v6 4/5] power: modify return of queue_stopped Miao Li
2021-10-15 17:09 ` [dpdk-dev] [PATCH v6 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-10-18 14:16 ` [dpdk-dev] [PATCH v7 0/5] Implement rte_power_monitor API in virtio/vhost PMD Miao Li
2021-10-18 14:16 ` [dpdk-dev] [PATCH v7 1/5] net/virtio: implement rte_power_monitor API Miao Li
2021-10-21 16:50 ` Ferruh Yigit
2021-10-22 8:22 ` Li, Miao
2021-10-21 16:59 ` Ferruh Yigit
2021-10-22 8:28 ` Li, Miao
2021-10-22 8:51 ` Li, Miao
2021-10-22 8:59 ` Ferruh Yigit
2021-10-22 9:02 ` Xia, Chenbo
2021-10-22 13:41 ` David Hunt
2021-10-18 14:16 ` [dpdk-dev] [PATCH v7 2/5] vhost: " Miao Li
2021-10-19 4:38 ` Xia, Chenbo
2021-10-22 12:34 ` David Hunt
2021-10-18 14:16 ` [dpdk-dev] [PATCH v7 3/5] net/vhost: " Miao Li
2021-10-19 4:39 ` Xia, Chenbo
2021-10-22 12:01 ` David Hunt
2021-10-18 14:16 ` [dpdk-dev] [PATCH v7 4/5] power: modify return of queue_stopped Miao Li
2021-10-21 16:48 ` Ferruh Yigit
2021-10-22 8:20 ` Li, Miao
2021-10-22 9:01 ` Ferruh Yigit
2021-10-22 9:05 ` Li, Miao [this message]
2021-10-22 11:54 ` David Hunt
2021-10-18 14:16 ` [dpdk-dev] [PATCH v7 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-10-19 4:39 ` Xia, Chenbo
2021-10-22 11:50 ` David Hunt
2021-10-21 16:58 ` Ferruh Yigit
2021-10-21 12:35 ` [dpdk-dev] [PATCH v7 0/5] Implement rte_power_monitor API in virtio/vhost PMD Maxime Coquelin
2021-10-25 14:47 ` [dpdk-dev] [PATCH v8 0/5] Support power monitor " Miao Li
2021-10-25 7:06 ` Xia, Chenbo
2021-10-28 8:03 ` Maxime Coquelin
2021-10-25 14:47 ` [dpdk-dev] [PATCH v8 1/5] net/virtio: support power monitor Miao Li
2021-10-25 14:47 ` [dpdk-dev] [PATCH v8 2/5] vhost: add power monitor support API Miao Li
2021-10-25 14:47 ` [dpdk-dev] [PATCH v8 3/5] net/vhost: support power monitor Miao Li
2021-10-25 14:47 ` [dpdk-dev] [PATCH v8 4/5] power: modify return of queue_stopped Miao Li
2021-10-25 14:47 ` [dpdk-dev] [PATCH v8 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-10-29 19:09 ` Ferruh Yigit
2021-10-29 10:34 ` [dpdk-dev] [PATCH v8 0/5] Support power monitor in virtio/vhost PMD Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB4900BC0011100E24F0889636EE809@CO1PR11MB4900.namprd11.prod.outlook.com \
--to=miao.li@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=chenbo.xia@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).