patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Zeng, ZhichaoX" <zhichaox.zeng@intel.com>
To: Harman Kalra <hkalra@marvell.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	"Yang, Qiming" <qiming.yang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Zeng, ZhichaoX" <zhichaox.zeng@intel.com>
Subject: RE: [PATCH v4] lib/eal: fix segfaults due to thread exit order
Date: Thu, 30 Jun 2022 10:38:37 +0000	[thread overview]
Message-ID: <CO6PR11MB560208F9415EE14EEB3C6C22F1BA9@CO6PR11MB5602.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CO6PR11MB5602BDB05B3DC9F2C2488889F1B49@CO6PR11MB5602.namprd11.prod.outlook.com>

Hi Harman, Bruce
    Could you please help to review this patch, thank you so much!

Best regards
Zhichao

> -----Original Message-----
> From: Zeng, ZhichaoX <zhichaox.zeng@intel.com> 
> Sent: Wednesday, June 15, 2022 2:02 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; david.marchand@redhat.com; stephen@networkplumber.org; mb@smartsharesystems.com; Zeng, ZhichaoX <zhichaox.zeng@intel.com>; Richardson, Bruce > <bruce.richardson@intel.com>; Harman Kalra <hkalra@marvell.com>
> Subject: [PATCH v4] lib/eal: fix segfaults due to thread exit order
>
> From: Zhichao Zeng <zhichaox.zeng@intel.com>
>
> The eal-intr-thread is not closed before memory cleanup in the process of exiting. There is a small probability that when the eal-intr-thread is about to use some pointers, the memory were just cleaned, which cause the > segment fault error caught by ASan.
>
> This patch close the eal-intr-thread before memory cleanup when exiting to avoid segment fault. And add some atomic operations to avoid executing rte_eal_cleanup in the child process spawned by fork() in some test > cases, e.g. debug_autotest of dpdk-test.
>
> Cc: stable@dpdk.org
>
> ---
> v2:
> add the same API for FreeBSD
> ---
> v3:
> fix rte_eal_cleanup crash in debug_autotest
> ---
> v4:
> shorten the prompt message and optimize the commit log
>
> Suggested-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>

  parent reply	other threads:[~2022-06-30 10:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220523111642.10406-1-zhichaox.zeng@intel.com>
2022-05-30 13:47 ` [PATCH v3] " zhichaox.zeng
2022-05-30 16:26   ` Stephen Hemminger
2022-05-30 16:28   ` Stephen Hemminger
2022-06-02  8:21     ` Zeng, ZhichaoX
2022-06-07 10:14   ` Zeng, ZhichaoX
2022-06-15  6:01   ` [PATCH v4] " zhichaox.zeng
2022-06-24  1:42     ` Zeng, ZhichaoX
2022-06-24  7:50       ` David Marchand
2022-06-30 10:38       ` Zeng, ZhichaoX [this message]
2022-06-30 12:24     ` Bruce Richardson
2022-09-06  2:51     ` [PATCH v5] lib/eal: fix segfaults in exiting Zhichao Zeng
2022-09-06 15:03       ` Stephen Hemminger
2022-09-07  8:53         ` Zeng, ZhichaoX
2022-10-11  5:25       ` [PATCH v6] " Zhichao Zeng
2022-10-11 14:04         ` Stephen Hemminger
2022-10-19  1:51           ` Zeng, ZhichaoX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO6PR11MB560208F9415EE14EEB3C6C22F1BA9@CO6PR11MB5602.namprd11.prod.outlook.com \
    --to=zhichaox.zeng@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=hkalra@marvell.com \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).