From: "Zeng, ZhichaoX" <zhichaox.zeng@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Tang, Yaqi" <yaqi.tang@intel.com>,
"Han, YingyaX" <yingyax.han@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>
Subject: RE: [PATCH v2 3/3] net/iavf: support Rx timestamp offload on SSE
Date: Thu, 27 Apr 2023 01:38:53 +0000 [thread overview]
Message-ID: <CO6PR11MB56023C39E8EC5702A3918282F16A9@CO6PR11MB5602.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8xqC5VN0n=xYab9c52erte7XU5AgrTU5t3RPaJ6QG3Fcw@mail.gmail.com>
Hi David,
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Wednesday, April 26, 2023 11:32 PM
> To: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Tang, Yaqi
> <yaqi.tang@intel.com>; Han, YingyaX <yingyax.han@intel.com>; Richardson,
> Bruce <bruce.richardson@intel.com>; Konstantin Ananyev
> <konstantin.v.ananyev@yandex.ru>; Wu, Jingjing <jingjing.wu@intel.com>;
> Xing, Beilei <beilei.xing@intel.com>
> Subject: Re: [PATCH v2 3/3] net/iavf: support Rx timestamp offload on SSE
>
> On Wed, Apr 12, 2023 at 10:42 AM Zhichao Zeng <zhichaox.zeng@intel.com>
> wrote:
> [snip]
> > +#ifndef RTE_LIBRTE_IAVF_16BYTE_RX_DESC #pragma GCC diagnostic
> push
> > +#pragma GCC diagnostic ignored "-Wimplicit-fallthrough"
> > + if (rxq->offloads & RTE_ETH_RX_OFFLOAD_TIMESTAMP) {
> > + inflection_point = (inflection_point <= var) ? inflection_point :
> 0;
> > + switch (inflection_point) {
> > + case 1:
> > + *RTE_MBUF_DYNFIELD(rx_pkts[pos + 0],
> > + iavf_timestamp_dynfield_offset + 4, uint32_t *) += 1;
> > + case 2:
> > + *RTE_MBUF_DYNFIELD(rx_pkts[pos + 1],
> > + iavf_timestamp_dynfield_offset + 4, uint32_t *) += 1;
> > + case 3:
> > + *RTE_MBUF_DYNFIELD(rx_pkts[pos + 2],
> > + iavf_timestamp_dynfield_offset + 4, uint32_t *) += 1;
> > + case 4:
> > + *RTE_MBUF_DYNFIELD(rx_pkts[pos + 3],
> > + iavf_timestamp_dynfield_offset + 4, uint32_t *) += 1;
> > + rxq->phc_time += (uint64_t)1 << 32;
> > + case 0:
> > + break;
> > + default:
> > + printf("invalid inflection point for
> > +rx timestamp\n");
>
> No printf.
> For all 3 patches of this series, please replace with this driver dedicated
> macro for debug logging.
Thanks for your comments, I will replace them in the next version.
>
> --
> David Marchand
next prev parent reply other threads:[~2023-04-27 1:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 7:36 [PATCH " Zhichao Zeng
2023-04-12 6:50 ` [PATCH v2 " Zhichao Zeng
2023-04-26 7:46 ` Tang, Yaqi
2023-04-12 8:46 ` Zhichao Zeng
2023-04-26 15:31 ` David Marchand
2023-04-27 1:38 ` Zeng, ZhichaoX [this message]
2023-04-27 3:13 ` [PATCH v3 " Zhichao Zeng
2023-04-28 5:40 ` Tang, Yaqi
2023-05-26 2:43 ` [PATCH v4 " Zhichao Zeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR11MB56023C39E8EC5702A3918282F16A9@CO6PR11MB5602.namprd11.prod.outlook.com \
--to=zhichaox.zeng@intel.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=qi.z.zhang@intel.com \
--cc=yaqi.tang@intel.com \
--cc=yingyax.han@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).