From: Suanming Mou <suanmingm@nvidia.com>
To: Akhil Goyal <gakhil@marvell.com>,
Anoob Joseph <anoobj@marvell.com>,
"ciara.power@intel.com" <ciara.power@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXT] [PATCH] app/test-crypto-perf: add throughput OOP decryption
Date: Tue, 19 Mar 2024 09:06:01 +0000 [thread overview]
Message-ID: <CO6PR12MB5396BCE7091CA0BB643BEC96C12C2@CO6PR12MB5396.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CO6PR18MB44845503582CC19614FEE14BD82C2@CO6PR18MB4484.namprd18.prod.outlook.com>
> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Tuesday, March 19, 2024 4:23 PM
> To: Suanming Mou <suanmingm@nvidia.com>; Anoob Joseph
> <anoobj@marvell.com>; ciara.power@intel.com
> Cc: dev@dpdk.org
> Subject: RE: [EXT] [PATCH] app/test-crypto-perf: add throughput OOP decryption
>
> > > > + if (options->test == CPERF_TEST_TYPE_THROUGHPUT &&
> > > > + (options->aead_op == RTE_CRYPTO_AEAD_OP_DECRYPT ||
> > > > + options->cipher_op == RTE_CRYPTO_CIPHER_OP_DECRYPT) &&
> > > > + !options->out_of_place) {
> > > > + RTE_LOG(ERR, USER1, "Only out-of-place is allowed in
> > > > throughput decryption.\n");
> > > > + return -EINVAL;
> > > > + }
> > >
> > > This check is blocking cipher_only decryption which should pass
> > > irrespective of inplace/oop and Data correct/incorrect.
> >
> > Sorry, in that case I will remove "options->cipher_op ==
> > RTE_CRYPTO_CIPHER_OP_DECRYPT" and only kept " options->aead_op ==
> > RTE_CRYPTO_AEAD_OP_DECRYPT ", what do you think?
>
> I would suggest to check for "auth_op == RTE_CRYPTO_AUTH_OP_VERIFY"
> Instead of cipher_op.
I'm not sure. Since in AEAD OP, auth_op will always be RTE_CRYPTO_AUTH_OP_VERIFY, in that case even in place encrypt will be rejected.
If the combination here is too complicated, what about just remove that limits and let user to decide? If the input is not correct, PMD will reject it as well.
>
> Ciara, What do you suggest? You were also seeing some issues in this patch.
next prev parent reply other threads:[~2024-03-19 9:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 10:01 Suanming Mou
2024-03-14 18:44 ` [EXT] " Akhil Goyal
2024-03-19 1:57 ` Suanming Mou
2024-03-19 8:23 ` Akhil Goyal
2024-03-19 9:06 ` Suanming Mou [this message]
2024-03-19 9:32 ` Akhil Goyal
2024-03-19 11:43 ` Suanming Mou
2024-03-19 11:46 ` [PATCH v2] " Suanming Mou
2024-03-19 15:14 ` Power, Ciara
2024-03-20 0:14 ` Suanming Mou
2024-04-01 0:30 ` Suanming Mou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR12MB5396BCE7091CA0BB643BEC96C12C2@CO6PR12MB5396.namprd12.prod.outlook.com \
--to=suanmingm@nvidia.com \
--cc=anoobj@marvell.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).