From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
"juraj.linkes@pantheon.tech" <juraj.linkes@pantheon.tech>,
nd <nd@arm.com>, Ruifeng Wang <Ruifeng.Wang@arm.com>,
Bruce Richardson <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Chengwen Feng <fengchengwen@huawei.com>,
Wathsala Wathawana Vithanage <wathsala.vithanage@arm.com>,
Dhruv Tripathi <Dhruv.Tripathi@arm.com>
Subject: RE: [PATCH v2 3/3] config/arm: allow WFE to be enabled config time
Date: Sat, 10 Feb 2024 16:40:48 +0000 [thread overview]
Message-ID: <CO6PR18MB4084C8C7994A9DF5C314B178DE4A2@CO6PR18MB4084.namprd18.prod.outlook.com> (raw)
In-Reply-To: <39D1C1D6-9C52-4EDF-9498-9ED6030B5567@arm.com>
> -----Original Message-----
> From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Sent: Saturday, February 10, 2024 10:07 PM
> To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> Cc: Jerin Jacob <jerinj@marvell.com>; juraj.linkes@pantheon.tech; nd
> <nd@arm.com>; Ruifeng Wang <Ruifeng.Wang@arm.com>; Bruce Richardson
> <bruce.richardson@intel.com>; dev@dpdk.org; Chengwen Feng
> <fengchengwen@huawei.com>; Wathsala Wathawana Vithanage
> <wathsala.vithanage@arm.com>; Dhruv Tripathi <Dhruv.Tripathi@arm.com>
> Subject: [EXT] Re: [PATCH v2 3/3] config/arm: allow WFE to be enabled config
> time
>
> External Email
>
> ----------------------------------------------------------------------
>
>
> > On Feb 10, 2024, at 12:47 AM, Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com> wrote:
> >
> >>> On Feb 1, 2024, at 3:57 PM, pbhagavatula@marvell.com wrote:
> >>>
> >>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >>>
> >>> Allow RTE_ARM_USE_WFE to be enabled at meson configuration
> >>> time by passing it via c_args instead of modifying
> >>> `config/arm/meson.build`.
> >>>
> >>> Example usage:
> >>> meson build -Dc_args='-DRTE_ARM_USE_WFE' \
> >>> --cross-file config/arm/arm64_cn10k_linux_gcc
> >>>
> >>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >>> Acked-by: Chengwen Feng <fengchengwen@huawei.com>
> >>> Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>
> >>> ---
> >>> config/arm/meson.build | 4 +++-
> >>> 1 file changed, 3 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/config/arm/meson.build b/config/arm/meson.build
> >>> index 6f2308f2fa..3467bef466 100644
> >>> --- a/config/arm/meson.build
> >>> +++ b/config/arm/meson.build
> >>> @@ -17,7 +17,9 @@ flags_common = [
> >>> # ['RTE_ARM64_MEMCPY_ALIGN_MASK', 0xF],
> >>> # ['RTE_ARM64_MEMCPY_STRICT_ALIGN', false],
> >>>
> >>> - ['RTE_ARM_USE_WFE', false],
> >>> + # Enable use of ARM wait for event instruction.
> >>> + # ['RTE_ARM_USE_WFE', false],
> >>> +
> >> So, what is the default value for RTE_ARM_USE_WFE if the user does not
> pass
> >> the flag at the command line?
> >>
> >
> > All the checks related to RTE_ARM_USE_WFE see if it is defined or not
> >
> > #rg "RTE_ARM_USE_WFE"
> > config/arm/meson.build
> > 20: ['RTE_ARM_USE_WFE', false],
> > lib/eal/arm/rte_cpuflags.c
> > 166:#ifdef RTE_ARM_USE_WFE
> > lib/eal/arm/include/rte_pause_64.h
> > 15:#ifdef RTE_ARM_USE_WFE
> > lib/eal/arm/rte_power_intrinsics.c
> > 20:#ifdef RTE_ARM_USE_WFE
> > 84:#ifdef RTE_ARM_USE_WFE
> >
> > So default value would be not-defined.
> >
> >> Can we do it such a way that the flag passed on the command line takes
> >> precedence?
> >
> > No, we can't have checks based on flags passed via -Dc_args with the current
> meson(needs build_options() from 1.1.0).
> > Only option is to add via meson_option.txt which is not optimal for arch
> settings.
>
> Ack
> Do you expect the users to enable this flag by default for cn10k?
>
No, AFAIK only certain users are going to enable it, mostly L1.
> >
> >>
> >>> ['RTE_ARCH_ARM64', true],
> >>> ['RTE_CACHE_LINE_SIZE', 128]
> >>> ]
> >>> --
> >>> 2.25.1
> >>>
> >
next prev parent reply other threads:[~2024-02-10 16:40 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-21 9:36 [PATCH 1/2] config/arm: avoid mcpu and march conflicts pbhagavatula
2024-01-21 9:36 ` [PATCH 2/2] config/arm: add support for fallback march pbhagavatula
2024-01-22 6:30 ` Ruifeng Wang
2024-01-22 11:04 ` Juraj Linkeš
2024-01-22 12:16 ` [EXT] " Pavan Nikhilesh Bhagavatula
2024-01-22 16:29 ` Juraj Linkeš
2024-01-24 15:25 ` Pavan Nikhilesh Bhagavatula
2024-01-22 6:29 ` [PATCH 1/2] config/arm: avoid mcpu and march conflicts Ruifeng Wang
2024-01-22 10:55 ` Juraj Linkeš
2024-01-22 11:54 ` [EXT] " Pavan Nikhilesh Bhagavatula
2024-01-22 16:26 ` Juraj Linkeš
2024-01-24 15:21 ` Pavan Nikhilesh Bhagavatula
2024-01-29 8:44 ` Juraj Linkeš
2024-01-30 16:16 ` Pavan Nikhilesh Bhagavatula
2024-01-31 9:03 ` Juraj Linkeš
2024-02-01 21:57 ` [PATCH v2 1/3] " pbhagavatula
2024-02-01 21:57 ` [PATCH v2 2/3] config/arm: add support for fallback march pbhagavatula
2024-02-01 21:57 ` [PATCH v2 3/3] config/arm: allow WFE to be enabled config time pbhagavatula
2024-02-07 2:55 ` Honnappa Nagarahalli
2024-02-10 6:47 ` Pavan Nikhilesh Bhagavatula
2024-02-10 16:36 ` Honnappa Nagarahalli
2024-02-10 16:40 ` Pavan Nikhilesh Bhagavatula [this message]
2024-02-02 8:50 ` [PATCH v3 1/3] config/arm: avoid mcpu and march conflicts pbhagavatula
2024-02-02 8:50 ` [PATCH v3 2/3] config/arm: add support for fallback march pbhagavatula
2024-02-07 20:24 ` Wathsala Wathawana Vithanage
2024-02-02 8:50 ` [PATCH v3 3/3] config/arm: allow WFE to be enabled config time pbhagavatula
2024-02-10 16:56 ` Honnappa Nagarahalli
2024-02-12 19:21 ` Wathsala Wathawana Vithanage
2024-02-06 4:10 ` [PATCH v3 1/3] config/arm: avoid mcpu and march conflicts Wathsala Wathawana Vithanage
2024-02-06 4:44 ` Honnappa Nagarahalli
2024-02-06 10:21 ` Pavan Nikhilesh Bhagavatula
2024-02-07 0:01 ` Wathsala Wathawana Vithanage
2024-02-10 6:49 ` Pavan Nikhilesh Bhagavatula
2024-02-10 15:20 ` Honnappa Nagarahalli
2024-02-10 17:21 ` Honnappa Nagarahalli
2024-02-21 20:20 ` [PATCH v4 " pbhagavatula
2024-02-21 20:20 ` [PATCH v4 2/3] config/arm: add support for fallback march pbhagavatula
2024-02-22 10:47 ` Juraj Linkeš
2024-02-22 12:32 ` [EXT] " Pavan Nikhilesh Bhagavatula
2024-02-21 20:20 ` [PATCH v4 3/3] config/arm: allow WFE to be enabled config time pbhagavatula
2024-02-22 9:37 ` [PATCH v4 1/3] config/arm: avoid mcpu and march conflicts Juraj Linkeš
2024-02-22 9:49 ` [EXT] " Pavan Nikhilesh Bhagavatula
2024-02-22 12:45 ` [PATCH v5 " pbhagavatula
2024-02-22 12:45 ` [PATCH v5 2/3] config/arm: add support for fallback march pbhagavatula
2024-02-23 11:49 ` Juraj Linkeš
2024-02-26 7:11 ` [EXT] " Pavan Nikhilesh Bhagavatula
2024-02-26 7:31 ` Juraj Linkeš
2024-02-26 7:34 ` Juraj Linkeš
2024-02-22 12:45 ` [PATCH v5 3/3] config/arm: allow WFE to be enabled config time pbhagavatula
2024-02-23 11:19 ` [PATCH v5 1/3] config/arm: avoid mcpu and march conflicts Juraj Linkeš
2024-02-26 7:08 ` [EXT] " Pavan Nikhilesh Bhagavatula
2024-02-26 7:38 ` [PATCH v6 " pbhagavatula
2024-02-26 7:38 ` [PATCH v6 2/3] config/arm: add support for fallback march pbhagavatula
2024-02-26 7:38 ` [PATCH v6 3/3] config/arm: allow WFE to be enabled config time pbhagavatula
2024-03-06 15:49 ` [PATCH v7 1/3] config/arm: avoid mcpu and march conflicts pbhagavatula
2024-03-06 15:49 ` [PATCH v7 2/3] config/arm: add support for fallback march pbhagavatula
2024-03-06 15:49 ` [PATCH v7 3/3] config/arm: allow WFE to be enabled config time pbhagavatula
2024-03-07 3:57 ` [PATCH v7 1/3] config/arm: avoid mcpu and march conflicts Pavan Nikhilesh Bhagavatula
2024-03-14 11:38 ` [PATCH v8 1/5] " pbhagavatula
2024-03-14 11:38 ` [PATCH v8 2/5] config/arm: add armv9-a march support pbhagavatula
2024-03-14 11:38 ` [PATCH v8 3/5] config/arm: add crypto march feature to thunderxt83 pbhagavatula
2024-03-14 12:00 ` Jerin Jacob
2024-03-14 11:38 ` [PATCH v8 4/5] config/arm: add support for fallback march pbhagavatula
2024-03-14 11:38 ` [PATCH v8 5/5] config/arm: allow WFE to be enabled config time pbhagavatula
2024-03-15 11:17 ` [PATCH v8 1/5] config/arm: avoid mcpu and march conflicts Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB4084C8C7994A9DF5C314B178DE4A2@CO6PR18MB4084.namprd18.prod.outlook.com \
--to=pbhagavatula@marvell.com \
--cc=Dhruv.Tripathi@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=jerinj@marvell.com \
--cc=juraj.linkes@pantheon.tech \
--cc=nd@arm.com \
--cc=wathsala.vithanage@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).