From: Akhil Goyal <gakhil@marvell.com>
To: "Kundapura, Ganapati" <ganapati.kundapura@intel.com>,
dpdk-dev <dev@dpdk.org>,
"fanzhang.oss@gmail.com" <fanzhang.oss@gmail.com>,
"Ji, Kai" <kai.ji@intel.com>,
"Power, Ciara" <ciara.power@intel.com>,
"Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>,
"Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>,
"Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>,
Jerin Jacob <jerinjacobk@gmail.com>
Subject: RE: RFC: Using and renaming 8-bit reserved field of rte_crypto_op for implementation specific
Date: Wed, 13 Mar 2024 18:07:19 +0000 [thread overview]
Message-ID: <CO6PR18MB44843E5CE509E4E24AB5F22CD82A2@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <MW4PR11MB591137DE406BE3619A6D2873872B2@MW4PR11MB5911.namprd11.prod.outlook.com>
Hi Ganapati,
>> Is it not possible to use rte_event_crypto_adapter_enqueue
>> if you want to send the event context to cryptodev?
> [Ganapati] No, event crypto adapter sends only ev::event_ptr as rte_crypto_op to cryptodev and not event context.
>> While using rte_cryptodev_enqueue() all previous stage event context is meant to be lost and
>> It would send a new crypto request to cryptodev and is not supposed to be aware of event context.
> [Ganapati] Yes, proposal is for sending implementation specific value from eventdev to crypodev and vice versa
As discussed in a separate mail thread,
impl_opaque in rte_crypto_op is not generic and is specific to your use case.
The crypto dev wont be able to make difference whether to alter it (for any other usecase) or not(for event case).
As per definition of impl_opaque is meant to be consumed by driver. Hence this will contradict the usage.
Since impl_opaque in rte_crypto_op is exposed to driver. Drivers are free to use it.
You may consider using mbuf dynamic fields for setting some userdata for your use case for each packet.
See rte_security_dynfield and add a fastpath cryptodev API to set pkt userdata which is opaque to driver
(similar to rte_security_set_pkt_metadata).
Or else add a similar schema to introduce dynamic fields in rte_crypto_op.
Regards,
Akhil
prev parent reply other threads:[~2024-03-13 18:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 7:13 Kundapura, Ganapati
2024-03-05 16:47 ` Akhil Goyal
2024-03-06 4:57 ` Kundapura, Ganapati
2024-03-12 7:52 ` Kundapura, Ganapati
2024-03-12 8:10 ` Akhil Goyal
2024-03-12 12:02 ` Kundapura, Ganapati
2024-03-13 18:07 ` Akhil Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB44843E5CE509E4E24AB5F22CD82A2@CO6PR18MB4484.namprd18.prod.outlook.com \
--to=gakhil@marvell.com \
--cc=abhinandan.gujjar@intel.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=ganapati.kundapura@intel.com \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinjacobk@gmail.com \
--cc=kai.ji@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).