DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <gakhil@marvell.com>
To: Suanming Mou <suanmingm@nvidia.com>,
	Anoob Joseph <anoobj@marvell.com>,
	"ciara.power@intel.com" <ciara.power@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXT] [PATCH v2 1/2] app/test-crypto-perf: fix invalid memcmp results
Date: Thu, 1 Feb 2024 08:47:06 +0000	[thread overview]
Message-ID: <CO6PR18MB44843F15C11FA8167DDE73CBD8432@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20240105000323.903764-1-suanmingm@nvidia.com>

> The function memcmp() returns an integer less than, equal to,
> or greater than zero. In current code, if the first memcmp()
> returns less than zero and the second memcmp() returns greater
> than zero, the sum of results may still be 0 and indicates
> verify succussed.
> 
> This commit converts the return value to be zero or greater
> than zero. That will make sure the sum of results be correct.
> 
> Fixes: df52cb3b6e13 ("app/crypto-perf: move verify as single test type")
> 
> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
> Acked-by: Anoob Joseph <anoobj@marvell.com>
Cc: stable@dpdk.org
Series
Applied to dpdk-next-crypto

      parent reply	other threads:[~2024-02-01  8:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-03  3:56 [PATCH " Suanming Mou
2024-01-03  3:56 ` [PATCH 2/2] app/test-crypto-perf: fix encrypt operation verify Suanming Mou
2024-01-04  5:13   ` [EXT] " Anoob Joseph
2024-01-04  8:56     ` Suanming Mou
2024-01-03 11:33 ` [EXT] [PATCH 1/2] app/test-crypto-perf: fix invalid memcmp results Anoob Joseph
2024-01-05  0:03 ` [PATCH v2 " Suanming Mou
2024-01-05  0:03   ` [PATCH v2 2/2] app/test-crypto-perf: fix encrypt operation verify Suanming Mou
2024-01-05  4:44     ` [EXT] " Anoob Joseph
2024-01-12 16:21   ` [PATCH v2 1/2] app/test-crypto-perf: fix invalid memcmp results Power, Ciara
2024-02-01  8:47   ` Akhil Goyal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO6PR18MB44843F15C11FA8167DDE73CBD8432@CO6PR18MB4484.namprd18.prod.outlook.com \
    --to=gakhil@marvell.com \
    --cc=anoobj@marvell.com \
    --cc=ciara.power@intel.com \
    --cc=dev@dpdk.org \
    --cc=suanmingm@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).