From: Akhil Goyal <gakhil@marvell.com>
To: Brian Dooley <brian.dooley@intel.com>, Kai Ji <kai.ji@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXT] [PATCH v1] crypto/ipsec_mb: add digest encrypted feature in AESNI_MB
Date: Mon, 24 Apr 2023 05:46:12 +0000 [thread overview]
Message-ID: <CO6PR18MB448446E84D661DF168800835D8679@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20230421101310.420593-1-brian.dooley@intel.com>
> Subject: [EXT] [PATCH v1] crypto/ipsec_mb: add digest encrypted feature in
> AESNI_MB
> AESNI_MB PMD does not support Digest Encrypted. This patch adds partial
> support for this feature.
I do not get it, what is the point of adding partial support.
It should be added when it is supported.
Also whenever, you add, add in documentation as well.
>
> Signed-off-by: Brian Dooley <brian.dooley@intel.com>
> ---
> Some out-of-place tests are still failing.
> Only some in-place tests are passing.
> Working on adding support for this feature in v2.
You cannot just send half cooked patches.
> ---
> app/test/1.diff | 0
> drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 3 ++-
> 2 files changed, 2 insertions(+), 1 deletion(-)
> create mode 100644 app/test/1.diff
>
> diff --git a/app/test/1.diff b/app/test/1.diff
> new file mode 100644
> index 0000000000..e69de29bb2
This file is accidently added.
next prev parent reply other threads:[~2023-04-24 5:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 10:13 Brian Dooley
2023-04-24 5:46 ` Akhil Goyal [this message]
2023-04-24 13:49 ` [EXT] " Dooley, Brian
2023-07-20 10:38 ` [PATCH v1] crypto/ipsec_mb: add digest encrypted feature Brian Dooley
2023-08-21 14:42 ` [PATCH v2] " Brian Dooley
2023-08-25 8:41 ` [PATCH v3] " Brian Dooley
2023-09-05 15:12 ` [PATCH v4 0/2] Add Digest Encrypted to aesni_mb PMD Brian Dooley
2023-09-05 15:12 ` [PATCH v4 1/2] crypto/ipsec_mb: add digest encrypted feature Brian Dooley
2023-09-05 15:12 ` [PATCH v4 2/2] test/crypto: fix IV in some vectors Brian Dooley
2023-09-05 16:15 ` [PATCH v5 0/2] Add Digest Encrypted to aesni_mb PMD Brian Dooley
2023-09-05 16:15 ` [PATCH v5 1/2] crypto/ipsec_mb: add digest encrypted feature Brian Dooley
2023-09-05 16:15 ` [PATCH v5 2/2] test/crypto: fix IV in some vectors Brian Dooley
2023-09-07 10:26 ` [PATCH v5 0/2] Add Digest Encrypted to aesni_mb PMD Brian Dooley
2023-09-07 10:26 ` [PATCH v6 1/2] crypto/ipsec_mb: add digest encrypted feature Brian Dooley
2023-09-07 15:25 ` Power, Ciara
2023-09-07 16:12 ` [PATCH v7 0/3] Add Digest Encrypted to aesni_mb PMD Brian Dooley
2023-09-07 16:12 ` [PATCH v7 1/3] crypto/ipsec_mb: add digest encrypted feature Brian Dooley
2023-09-07 16:12 ` [PATCH v7 2/3] test/crypto: fix IV in some vectors Brian Dooley
2023-09-07 16:12 ` [PATCH v7 3/3] test/crypto: fix failing synchronous tests Brian Dooley
2023-09-14 15:22 ` [PATCH v8 0/3] Add Digest Encrypted to aesni_mb PMD Brian Dooley
2023-09-14 15:22 ` [PATCH v8 1/3] crypto/ipsec_mb: add digest encrypted feature Brian Dooley
2023-09-19 6:02 ` [EXT] " Akhil Goyal
2023-09-14 15:22 ` [PATCH v8 2/3] test/crypto: fix IV in some vectors Brian Dooley
2023-09-14 15:22 ` [PATCH v8 3/3] test/crypto: fix failing synchronous tests Brian Dooley
2023-09-07 10:26 ` [PATCH v6 2/2] test/crypto: fix IV in some vectors Brian Dooley
2023-09-07 15:25 ` Power, Ciara
2023-09-19 10:42 ` [PATCH v9 0/3] Add Digest Encrypted to aesni_mb PMD Brian Dooley
2023-09-19 10:42 ` [PATCH v9 1/3] crypto/ipsec_mb: add digest encrypted feature Brian Dooley
2023-09-19 10:42 ` [PATCH v9 2/3] test/crypto: fix IV in some vectors Brian Dooley
2023-09-19 10:42 ` [PATCH v9 3/3] test/crypto: fix failing synchronous tests Brian Dooley
2023-09-19 12:28 ` [EXT] [PATCH v9 0/3] Add Digest Encrypted to aesni_mb PMD Akhil Goyal
2023-09-21 7:13 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB448446E84D661DF168800835D8679@CO6PR18MB4484.namprd18.prod.outlook.com \
--to=gakhil@marvell.com \
--cc=brian.dooley@intel.com \
--cc=dev@dpdk.org \
--cc=kai.ji@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).