From: Akhil Goyal <gakhil@marvell.com>
To: Arek Kusztal <arkadiuszx.kusztal@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>, Kai Ji <kai.ji@intel.com>
Subject: RE: [EXT] [PATCH 1/2] cryptodev: add option to use ec base point in ecpm
Date: Fri, 30 Sep 2022 17:52:18 +0000 [thread overview]
Message-ID: <CO6PR18MB448475BD381960023F415092D8569@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20220818074130.37894-2-arkadiuszx.kusztal@intel.com>
> Add option to use elliptic curve generator point instead
> of setting it manually. It corresponds to the public point
> generation in EC Diffie-Hellman key exchange.
>
The title talks about adding an option to use EC base point in ECPM
But the description and code changes does not match.
Can you please update this patch with appropriate title and description?
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
> lib/cryptodev/rte_crypto_asym.h | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h
> index 8ae43d5f3d..62987f860e 100644
> --- a/lib/cryptodev/rte_crypto_asym.h
> +++ b/lib/cryptodev/rte_crypto_asym.h
> @@ -593,7 +593,11 @@ struct rte_crypto_ecdsa_op_param {
> */
> struct rte_crypto_ecpm_op_param {
> struct rte_crypto_ec_point p;
> - /**< x and y coordinates of input point */
> + /**<
> + * x and y coordinates of input point,
> + * in case both x.data and y.data are set to NULL
> + * selected ellitpic curve generator point is used
> + */
>
> struct rte_crypto_ec_point r;
> /**< x and y coordinates of resultant point */
> --
> 2.13.6
next prev parent reply other threads:[~2022-09-30 17:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 7:41 [PATCH 0/2] cryptodev: extend elliptic curves operations Arek Kusztal
2022-08-18 7:41 ` [PATCH 1/2] cryptodev: add option to use ec base point in ecpm Arek Kusztal
2022-09-28 17:56 ` Ji, Kai
2022-09-30 17:52 ` Akhil Goyal [this message]
2022-08-18 7:41 ` [PATCH 2/2] cryptodev: add ec point verification Arek Kusztal
2022-09-28 17:58 ` Ji, Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB448475BD381960023F415092D8569@CO6PR18MB4484.namprd18.prod.outlook.com \
--to=gakhil@marvell.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=dev@dpdk.org \
--cc=kai.ji@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).