From: Akhil Goyal <gakhil@marvell.com>
To: David Christensen <drc@linux.vnet.ibm.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"radu.nicolau@intel.com" <radu.nicolau@intel.com>
Subject: RE: [EXT] [PATCH] examples/ipsec-secgw: Update fixed MAC address used by tap driver
Date: Tue, 16 May 2023 10:28:43 +0000 [thread overview]
Message-ID: <CO6PR18MB4484B68A1BADD1BDF0553EE0D8799@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20230426203724.1008261-1-drc@linux.vnet.ibm.com>
> Modify LOCAL_MAC value to match new locally administered MAC
> address used by TAP driver.
>
Shouldn't this be other way round?
PMD should be able to use the MAC given by application.
> Bugzilla ID: 1198
>
> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
> ---
> examples/ipsec-secgw/test/common_defs.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/ipsec-secgw/test/common_defs.sh b/examples/ipsec-
> secgw/test/common_defs.sh
> index 3ef06bc761..6e04ffc1a6 100644
> --- a/examples/ipsec-secgw/test/common_defs.sh
> +++ b/examples/ipsec-secgw/test/common_defs.sh
> @@ -26,7 +26,7 @@ fi
>
> LOCAL_IFACE=dtap0
>
> -LOCAL_MAC="00:64:74:61:70:30"
> +LOCAL_MAC="02:64:74:61:70:30"
>
> REMOTE_IPV4=192.168.31.14
> LOCAL_IPV4=192.168.31.92
> --
> 2.31.1
prev parent reply other threads:[~2023-05-16 10:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 20:37 David Christensen
2023-05-16 10:28 ` Akhil Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB4484B68A1BADD1BDF0553EE0D8799@CO6PR18MB4484.namprd18.prod.outlook.com \
--to=gakhil@marvell.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=radu.nicolau@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).