From: Akhil Goyal <gakhil@marvell.com>
To: Kai Ji <kai.ji@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXT] [dpdk-dev v1] crypto/openssl: fix of dstlen passed in HMAC
Date: Fri, 26 Aug 2022 08:55:38 +0000 [thread overview]
Message-ID: <CO6PR18MB4484BE9C77C647CBB340832DD8759@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20220711170810.60624-1-kai.ji@intel.com>
> Subject: [EXT] [dpdk-dev v1] crypto/openssl: fix of dstlen passed in HMAC
>
Title can be reworded
Crypto/openssl: fix HMAC output length
> This fix of dstlen passed in OpenSSL 3.0 lib EVP MAC final routine.
Please reword the description to explain what is not correct and what is done to fix it.
>
> Fixes: 75adf1eae44f ("crypto/openssl: update HMAC routine with 3.0 EVP API")
>
> Signed-off-by: Kai Ji <kai.ji@intel.com>
> ---
> drivers/crypto/openssl/rte_openssl_pmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c
> b/drivers/crypto/openssl/rte_openssl_pmd.c
> index e01dacc98d..5658b9db66 100644
> --- a/drivers/crypto/openssl/rte_openssl_pmd.c
> +++ b/drivers/crypto/openssl/rte_openssl_pmd.c
> @@ -1395,7 +1395,7 @@ process_openssl_auth_hmac(struct rte_mbuf
> *mbuf_src, uint8_t *dst, int offset,
> }
>
> process_auth_final:
> - if (EVP_MAC_final(ctx, dst, &dstlen, sizeof(dst)) != 1)
> + if (EVP_MAC_final(ctx, dst, &dstlen, DIGEST_LENGTH_MAX) != 1)
> goto process_auth_err;
>
> EVP_MAC_CTX_free(ctx);
> --
> 2.17.1
next prev parent reply other threads:[~2022-08-26 8:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 17:08 Kai Ji
2022-07-19 9:49 ` Zhang, Roy Fan
2022-08-26 8:55 ` Akhil Goyal [this message]
2022-08-31 15:09 ` [dpdk-dev v2] crypto/openssl: fix HMAC output length Kai Ji
2022-09-22 16:07 ` [EXT] " Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB4484BE9C77C647CBB340832DD8759@CO6PR18MB4484.namprd18.prod.outlook.com \
--to=gakhil@marvell.com \
--cc=dev@dpdk.org \
--cc=kai.ji@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).