From: Akhil Goyal <gakhil@marvell.com>
To: "Power, Ciara" <ciara.power@intel.com>,
Volodymyr Fialko <vfialko@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>, Fan Zhang <fanzhang.oss@gmail.com>,
"Ji, Kai" <kai.ji@intel.com>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Anoob Joseph <anoobj@marvell.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"Ji, Kai" <kai.ji@intel.com>,
Volodymyr Fialko <vfialko@marvell.com>
Subject: RE: [PATCH v5] test: add cryptodev crosscheck suite
Date: Thu, 16 Mar 2023 18:35:26 +0000 [thread overview]
Message-ID: <CO6PR18MB4484EDEDC10F417286BBB84ED8BC9@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <SN7PR11MB76397732FD56A91327324628E6BC9@SN7PR11MB7639.namprd11.prod.outlook.com>
> Hi Akhil, Volodymyr
>
> > Subject: RE: [PATCH v5] test: add cryptodev crosscheck suite
> >
> >
> > > Subject: [PATCH v5] test: add cryptodev crosscheck suite
> > >
> > > Add a validation test suite that helps in verifying that the output
> > > generated by two different cryptodevs match for a wide range of input
> > > parameter combinations.
> > >
> > > Crypto autotest performs a comprehensive testing of the cryptodev but
> > > since it performs verification by comparing against known vectors, the
> > > extend to which various parameters (like packet size) can be tested is
> > > limited. This test suite attempts to simulate various cases by running
> > > same test case on different cryptodevs and compares the output
> > > generated. The test suite relies on capabilities to determine the
> > > combinations of tests to be attempted.
> > >
> > > A typical use case would be to compare outputs generated from a
> > > standard driver such as openSSL PMD and a new cryptodev PMD. This test
> > > suite is to compliment the testing coverage that crypto autotest provides.
> > >
> > > Currently supported symmetric xforms(cipher, auth, aead) without chaining.
> > >
> > > Example commands:
> > > DPDK_TEST=cryptodev_crosscheck ./dpdk-test \
> > > --vdev "crypto_openssl0" --vdev "crypto_openssl1"
> > > DPDK_TEST=cryptodev_crosscheck ./dpdk-test \
> > > -a <cryptodev> --vdev "crypto_openssl"
> > >
> > > Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
> > > ---
> > > V2:
> > > - Updated commit message.
> > > V3:
> > > - Removed usage of deprecated crypto strings API.
> > > V4:
> > > - Reworked cryptodev capabilities scan procedure
> > > - Moved AAD and digest from rte_mbuf to separated memory
> > > - Released allocated memory
> > > V5:
> > > - Fixed coding style issues
> > Hi Ciara,
> >
> > Can you check if this version works for you and ack if all good?
> >
> > Regards,
> > Akhil
>
> Thanks for those fixes in v4 - the openssl issues I saw previously are fixed now.
>
> When I try openssl/QAT or aesni_mb/QAT, the tests skip with no common
> capabilities.
> I think this might be an error on QAT side, that capabilities aren't retrieved
> correctly maybe.
> Needs further debugging on our side for that, but we have a bank holiday in
> Ireland tomorrow so it may be delayed.
>
> Happy to ack this patch anyway, seeing as the tests look good for the other
> devices I tested.
>
> Thanks,
> Acked-by: Ciara Power <ciara.power@intel.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
Applied to dpdk-next-crypto
Title updated to " test/crypto: add device crosscheck suite"
next prev parent reply other threads:[~2023-03-16 18:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 11:08 [PATCH] " Volodymyr Fialko
2023-02-09 12:34 ` [PATCH v2] " Volodymyr Fialko
2023-02-09 14:34 ` [PATCH v3] " Volodymyr Fialko
2023-03-14 13:32 ` [PATCH v4] " Volodymyr Fialko
2023-03-14 13:56 ` [PATCH v5] " Volodymyr Fialko
2023-03-16 9:44 ` Akhil Goyal
2023-03-16 15:46 ` Power, Ciara
2023-03-16 18:35 ` Akhil Goyal [this message]
2023-03-08 17:30 ` [PATCH v2] " Power, Ciara
2023-03-14 13:33 ` Volodymyr Fialko
2023-03-08 18:03 ` Power, Ciara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB4484EDEDC10F417286BBB84ED8BC9@CO6PR18MB4484.namprd18.prod.outlook.com \
--to=gakhil@marvell.com \
--cc=anoobj@marvell.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=kai.ji@intel.com \
--cc=vfialko@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).