From: "Roberts, Lee A." <lee.roberts@hpe.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] kni: fix compilation under RHEL 7.5
Date: Fri, 2 Mar 2018 03:18:51 +0000 [thread overview]
Message-ID: <CS1PR8401MB0949CF5C75958CE06B52D3EEE5C50@CS1PR8401MB0949.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20180301161815.6c7771a6@xeon-e3>
> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Thursday, March 01, 2018 5:18 PM
> To: Roberts, Lee A. <lee.roberts@hpe.com>
> Cc: ferruh.yigit@intel.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] kni: fix compilation under RHEL 7.5
>
> On Thu, 1 Mar 2018 16:20:35 -0700
> Lee Roberts <lee.roberts@hpe.com> wrote:
>
> > Fix kni compilation under RHEL 7.5.
> >
> > Signed-off-by: Lee Roberts <lee.roberts@hpe.com>
> > ---
> > lib/librte_eal/linuxapp/kni/compat.h | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/lib/librte_eal/linuxapp/kni/compat.h b/lib/librte_eal/linuxapp/kni/compat.h
> > index 3f8c0bc..6a6968d 100644
> > --- a/lib/librte_eal/linuxapp/kni/compat.h
> > +++ b/lib/librte_eal/linuxapp/kni/compat.h
> > @@ -101,6 +101,11 @@
> > #undef NET_NAME_UNKNOWN
> > #endif
> >
> > +#if (defined(RHEL_RELEASE_CODE) && \
> > + (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)))
> > +#define ndo_change_mtu ndo_change_mtu_rh74
> > +#endif
> > +
> > #if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 11, 0)
> > #define HAVE_SIGNAL_FUNCTIONS_OWN_HEADER
> > #endif
>
> Do we really want upstream DPDK trying to track every vendor kernel compatibility wart?
> Should Redhat be owning this in their own DPDK package?
If I look at the first few lines of ../lib/librte_eal/linuxapp/kni/compat.h,
it appears that tracking changes in RHEL and SLES is certainly part of the
purpose of this file:
1 /*
2 * Minimal wrappers to allow compiling kni on older kernels.
3 */
4
5 #include <linux/version.h>
6
7 #ifndef RHEL_RELEASE_VERSION
8 #define RHEL_RELEASE_VERSION(a, b) (((a) << 8) + (b))
9 #endif
10
11 /* SuSE version macro is the same as Linux kernel version */
12 #ifndef SLE_VERSION
13 #define SLE_VERSION(a, b, c) KERNEL_VERSION(a, b, c)
14 #endif
15 #ifdef CONFIG_SUSE_KERNEL
If you want to remove the vendor dependency, I'd suggest the following actions:
1) Submit a patch to remove the RHEL- and SLES-specific code.
2) Disable KNI by default in the build system.
- Lee
next prev parent reply other threads:[~2018-03-02 3:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 23:20 Lee Roberts
2018-03-02 0:18 ` Stephen Hemminger
2018-03-02 3:18 ` Roberts, Lee A. [this message]
2018-03-22 18:07 ` Ferruh Yigit
2018-03-27 22:15 ` Thomas Monjalon
2018-04-19 13:09 ` Maxime Coquelin
2018-04-19 21:49 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CS1PR8401MB0949CF5C75958CE06B52D3EEE5C50@CS1PR8401MB0949.NAMPRD84.PROD.OUTLOOK.COM \
--to=lee.roberts@hpe.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).