From: "Singh, Jasvinder" <jasvinder.singh@intel.com>
To: "Dharmappa, Savinay" <savinay.dharmappa@intel.com>,
"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] sched : Initialize tc ov watermark.
Date: Wed, 10 Mar 2021 16:53:50 +0000 [thread overview]
Message-ID: <CY4PR1101MB2134020396DA1C1E1369CFC8E0919@CY4PR1101MB2134.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210309161002.31384-1-savinay.dharmappa@intel.com>
> -----Original Message-----
> From: Dharmappa, Savinay <savinay.dharmappa@intel.com>
> Sent: Tuesday, March 9, 2021 4:10 PM
> To: Singh, Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; dev@dpdk.org
> Cc: Dharmappa, Savinay <savinay.dharmappa@intel.com>
> Subject: [PATCH v2] sched : Initialize tc ov watermark.
>
> tc ov watermark is initialized with computed value of max tc ov watermark.
>
> Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
> ---
> v2: fix spelling error.
> ---
> lib/librte_sched/rte_sched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c index
> 7c56880681..cd87e688e4 100644
> --- a/lib/librte_sched/rte_sched.c
> +++ b/lib/librte_sched/rte_sched.c
> @@ -1249,7 +1249,6 @@ rte_sched_subport_config(struct rte_sched_port
> *port, #ifdef RTE_SCHED_SUBPORT_TC_OV
> /* TC oversubscription */
> s->tc_ov_wm_min = port->mtu;
> - s->tc_ov_wm = s->tc_ov_wm_max;
> s->tc_ov_period_id = 0;
> s->tc_ov = 0;
> s->tc_ov_n = 0;
> @@ -1277,6 +1276,7 @@ rte_sched_subport_config(struct rte_sched_port
> *port, #ifdef RTE_SCHED_SUBPORT_TC_OV
> s->tc_ov_wm_max = rte_sched_time_ms_to_bytes(profile-
> >tc_period,
> s-
> >pipe_tc_be_rate_max);
> + s->tc_ov_wm = s->tc_ov_wm_max;
> #endif
> s->profile = subport_profile_id;
>
> --
> 2.17.1
Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
next prev parent reply other threads:[~2021-03-10 16:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 16:01 [dpdk-dev] [PATCH v1] " Savinay Dharmappa
2021-03-09 16:10 ` [dpdk-dev] [PATCH v2] " Savinay Dharmappa
2021-03-10 16:53 ` Singh, Jasvinder [this message]
2021-03-15 16:42 ` Coyle, David
2021-03-23 16:02 ` Thomas Monjalon
2021-04-20 10:13 ` Thomas Monjalon
2021-04-20 10:36 ` Singh, Jasvinder
2021-04-20 13:54 ` Thomas Monjalon
2021-04-21 6:50 ` [dpdk-dev] [PATCH v3] sched : fix traffic class oversubscription parameter Savinay Dharmappa
2021-04-21 14:53 ` Thomas Monjalon
2021-04-21 15:24 ` Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR1101MB2134020396DA1C1E1369CFC8E0919@CY4PR1101MB2134.namprd11.prod.outlook.com \
--to=jasvinder.singh@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=savinay.dharmappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).