From: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>
To: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Trahe, Fiona" <fiona.trahe@intel.com>,
"ruifeng.wang@arm.com" <ruifeng.wang@arm.com>,
"michaelsh@marvell.com" <michaelsh@marvell.com>,
Anoob Joseph <anoobj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v2 4/5] cryptodev: remove list ends from asymmetric crypto api
Date: Fri, 9 Oct 2020 07:02:11 +0000 [thread overview]
Message-ID: <CY4PR11MB1830FE53D10802FAD0220B2A9F080@CY4PR11MB1830.namprd11.prod.outlook.com> (raw)
In-Reply-To: <VI1PR04MB3168C356D7975B4F7529C33DE60B0@VI1PR04MB3168.eurprd04.prod.outlook.com>
Hi Akhil,
> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: czwartek, 8 października 2020 21:51
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; ruifeng.wang@arm.com;
> michaelsh@marvell.com
> Subject: RE: [PATCH v2 4/5] cryptodev: remove list ends from asymmetric crypto
> api
>
> Hi Arek/Fiona,
>
> > This patch removes RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END,
> > RTE_CRYPTO_ASYM_OP_LIST_END,
> > RTE_CRYPTO_RSA_PADDING_TYPE_LIST_END
> > enumerators from asymmetric crypto API. When asymmetric API will no
> > more be experimental adding new entries will be possible without ABI
> > breakage.
>
> I believe XFORM_TYPE, ASYM_OP, and PADDING_TYPE are not going to Change
> in near future. Hence LIST_END should not be removed from these Enums.
> Adding a LIST END has its own benefits and we should not remove that until we
> have a solid reason for it. Moreover, these are experimental.
> We should revisit these when we think ASYM is stable.
As for XFORM_TYPE it could be extended by ECDH, even if ECPM is present (as we have DH op enums), I think EdDSA can have its own enum as well.
As for asym_op I don't know which way it will go as RTE_CRYPTO_ASYM_OP_PRIVATE_KEY_GENERATE is distinct case as it is more about generation than computation, this could be clarified in future.
As for rsa padding, I agree it fulfills today requirements.
Though yes, since it is experimental I will remove asym patch from v3 patchset.
>
> IMO, we should only remove list ends in algo types.
>
> Regards,
> Akhil
next prev parent reply other threads:[~2020-10-09 7:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 17:32 [dpdk-dev] [PATCH v2 0/5] cryptodev: remove list end enumerators Arek Kusztal
2020-09-30 17:32 ` [dpdk-dev] [PATCH v2 1/5] app/test: remove list end references from asym crypto Arek Kusztal
2020-09-30 17:32 ` [dpdk-dev] [PATCH v2 2/5] crypto/qat: remove asym list end references Arek Kusztal
2020-09-30 17:32 ` [dpdk-dev] [PATCH v2 3/5] cryptodev: remove crypto list end enumerators Arek Kusztal
2020-10-08 19:58 ` Akhil Goyal
2020-10-12 5:15 ` Kusztal, ArkadiuszX
2020-10-12 11:46 ` Akhil Goyal
2020-09-30 17:32 ` [dpdk-dev] [PATCH v2 4/5] cryptodev: remove list ends from asymmetric crypto api Arek Kusztal
2020-10-08 19:51 ` Akhil Goyal
2020-10-09 7:02 ` Kusztal, ArkadiuszX [this message]
2020-09-30 17:32 ` [dpdk-dev] [PATCH v2 5/5] doc: remove crypto list end deprecation notice Arek Kusztal
2020-10-01 9:49 ` [dpdk-dev] [PATCH v2 0/5] cryptodev: remove list end enumerators Trahe, Fiona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR11MB1830FE53D10802FAD0220B2A9F080@CY4PR11MB1830.namprd11.prod.outlook.com \
--to=arkadiuszx.kusztal@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=michaelsh@marvell.com \
--cc=ruifeng.wang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).