DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
	Kiran Kumar Kokkilagadda <kirankumark@marvell.com>,
	John McNamara <john.mcnamara@intel.com>,
	Marko Kovacevic <marko.kovacevic@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v4] net/octeontx2: add set supported types op
Date: Fri, 15 Nov 2019 14:02:42 +0000	[thread overview]
Message-ID: <CY4PR1801MB1863264230E47F76926ABDE3DE700@CY4PR1801MB1863.namprd18.prod.outlook.com> (raw)
In-Reply-To: <6b061730-92d3-afac-c0c2-b66743aa36cd@intel.com>

>On 11/7/2019 2:52 AM, pbhagavatula@marvell.com wrote:
>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>
>> Add support to set supported ptypes for octeontx2.
>>
>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
><...>
>
>> @@ -62,6 +62,21 @@ otx2_nix_supported_ptypes_get(struct
>rte_eth_dev *eth_dev)
>>  		return NULL;
>>  }
>>
>> +int
>> +otx2_nix_ptypes_set(struct rte_eth_dev *eth_dev, uint32_t
>ptype_mask)
>> +{
>> +	struct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev);
>> +
>> +	if (ptype_mask)
>> +		dev->rx_offload_flags |= NIX_RX_OFFLOAD_PTYPE_F;
>> +	else
>> +		dev->rx_offload_flags &=
>~NIX_RX_OFFLOAD_PTYPE_F;
>> +
>> +	otx2_eth_set_rx_function(eth_dev);
>> +
>> +	return 0;
>
>Aren't you using 'ptype_mask' value? Is it just used to enable/disable?

Yes, currently it's just to enable/disable. Later we plan to resize our internal array.

      reply	other threads:[~2019-11-15 14:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-08  9:00 [dpdk-dev] [PATCH] " pbhagavatula
2019-10-11  8:02 ` Jerin Jacob
2019-10-17 12:20 ` [dpdk-dev] [PATCH v2] " pbhagavatula
2019-10-17 16:22   ` Jerin Jacob
2019-10-17 16:51   ` [dpdk-dev] [PATCH v3] " pbhagavatula
2019-11-07  2:52     ` [dpdk-dev] [PATCH v4] " pbhagavatula
2019-11-15 10:17       ` Jerin Jacob
2019-11-15 13:44       ` Ferruh Yigit
2019-11-15 14:02         ` Pavan Nikhilesh Bhagavatula [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR1801MB1863264230E47F76926ABDE3DE700@CY4PR1801MB1863.namprd18.prod.outlook.com \
    --to=pbhagavatula@marvell.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinj@marvell.com \
    --cc=john.mcnamara@intel.com \
    --cc=kirankumark@marvell.com \
    --cc=marko.kovacevic@intel.com \
    --cc=ndabilpuram@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).