From: "Sujith Sankar (ssujith)" <ssujith@cisco.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT
Date: Tue, 16 Dec 2014 04:12:41 +0000 [thread overview]
Message-ID: <D0B5AE42.2A9E2%ssujith@cisco.com> (raw)
In-Reply-To: <5911790.4rCTPaIceN@xps13>
On 16/12/14 4:54 am, "Thomas Monjalon" <thomas.monjalon@6wind.com> wrote:
>2014-12-12 13:48, Sujith Sankar:
>> This patch corrects the usage of the flag VFIO_PRESENT in enic driver.
>
>Please, could you explain why the flag VFIO_PRESENT was not well used?
Without including eal_vfio.h, VFIO_PRESENT is not available in enic.
Hence VFIO specific code in enic was not getting compiled and some errors
were generated during run-time.
>
>> This has uncovered a few warnings, and this patch corrects those too.
>[...]
>> --- a/lib/librte_pmd_enic/enic_main.c
>> +++ b/lib/librte_pmd_enic/enic_main.c
>> @@ -39,6 +39,7 @@
>> #include <sys/mman.h>
>> #include <fcntl.h>
>> #include <libgen.h>
>> +#include <sys/ioctl.h>
>>
>> #include <rte_pci.h>
>> #include <rte_memzone.h>
>> @@ -46,6 +47,7 @@
>> #include <rte_mbuf.h>
>> #include <rte_string_fns.h>
>> #include <rte_ethdev.h>
>> +#include <eal_vfio.h>
>
>This header was not designed to be included by PMDs.
>It will break compilation on BSD.
Is there an alternative to make VFIO_PRESENT available in enic? Please
advise.
Thanks,
-Sujith
>
>> #include "enic_compat.h"
>> #include "enic.h"
>> @@ -561,6 +563,7 @@ enic_free_consistent(__rte_unused struct
>>rte_pci_device *hwdev,
>> /* Nothing to be done */
>> }
>>
>> +#ifndef VFIO_PRESENT
>> static void
>> enic_intr_handler(__rte_unused struct rte_intr_handle *handle,
>> void *arg)
>> @@ -572,6 +575,7 @@ enic_intr_handler(__rte_unused struct
>>rte_intr_handle *handle,
>>
>> enic_log_q_error(enic);
>> }
>> +#endif
>
>--
>Thomas
next prev parent reply other threads:[~2014-12-16 4:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 8:18 Sujith Sankar
2014-12-15 23:24 ` Thomas Monjalon
2014-12-16 4:12 ` Sujith Sankar (ssujith) [this message]
2014-12-16 7:51 ` Qiu, Michael
2014-12-16 10:00 ` Sujith Sankar (ssujith)
2014-12-16 10:16 ` Thomas Monjalon
2014-12-16 10:22 ` Burakov, Anatoly
2014-12-16 10:34 ` Sujith Sankar (ssujith)
2014-12-16 10:36 ` Burakov, Anatoly
2014-12-16 10:40 ` Sujith Sankar (ssujith)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0B5AE42.2A9E2%ssujith@cisco.com \
--to=ssujith@cisco.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).