From: Yong Wang <yongwang@vmware.com>
To: John McNamara <john.mcnamara@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: fixed verbatim sections in vmxnet3 docs
Date: Mon, 13 Apr 2015 21:11:34 +0000 [thread overview]
Message-ID: <D1517A8E.3F09A%yongwang@vmware.com> (raw)
In-Reply-To: <1428677139-14607-1-git-send-email-john.mcnamara@intel.com>
On 4/10/15, 7:45 AM, "John McNamara" <john.mcnamara@intel.com> wrote:
>Fixed two verbatim text sections in vmxnet3 docs.
>
>Signed-off-by: John McNamara <john.mcnamara@intel.com>
This patch looks good.
Just want to point out that there are some places in the same doc that
needs fixing. For example, in the various diagrams, specific versions of
DPDK and ESXi are used. I understand that vmxnet3 pmd was introduced in
1.6 but I prefer them to be version-agonostic since the same diagram works
for 1.7, 1.8, etc and I don’t see much benefits in spelling out 1.6 in
this case. Same arguments to the ESXi version.
Acked-by: Yong Wang <yongwang@vmware.com>
>---
> doc/guides/nics/vmxnet3.rst | 27 ++++++++++++++++++++-------
> 1 file changed, 20 insertions(+), 7 deletions(-)
>
>diff --git a/doc/guides/nics/vmxnet3.rst b/doc/guides/nics/vmxnet3.rst
>index 3aa5b40..830530d 100644
>--- a/doc/guides/nics/vmxnet3.rst
>+++ b/doc/guides/nics/vmxnet3.rst
>@@ -149,10 +149,15 @@ This section describes an example setup for
>Phy-vSwitch-VM-Phy communication.
> Other instructions on preparing to use DPDK such as, hugepage
>enabling, uio port binding are not listed here.
> Please refer to *DPDK Getting Started Guide and DPDK Sample
>Application's User Guide* for detailed instructions.
>
>-The packet reception and transmission flow path is:
>+The packet reception and transmission flow path is::
>
>- Packet generator -> 82576 -> VMware ESXi vSwitch -> VMXNET3 device
>-> Guest VM VMXNET3 port 0 rx burst -> Guest
>- VM 82599 VF port 0 tx burst -> 82599 VF -> Packet generator
>+ Packet generator -> 82576
>+ -> VMware ESXi vSwitch
>+ -> VMXNET3 device
>+ -> Guest VM VMXNET3 port 0 rx burst
>+ -> Guest VM 82599 VF port 0 tx burst
>+ -> 82599 VF
>+ -> Packet generator
>
> VMXNET3 Chaining VMs Connected to a vSwitch
> -------------------------------------------
>@@ -166,7 +171,15 @@ The following figure shows an example VM-to-VM
>communication over a Phy-VM-vSwit
> When using the L2 Forwarding or L3 Forwarding applications,
> a destination MAC address needs to be written in packets to hit the
>other VM's VMXNET3 interface.
>
>-In this example, the packet flow path is:
>-
>- Packet generator -> 82599 VF -> Guest VM 82599 port 0 rx burst ->
>Guest VM VMXNET3 port 1 tx burst -> VMXNET3
>- device -> VMware ESXi vSwitch -> VMXNET3 device -> Guest VM VMXNET3
>port 0 rx burst -> Guest VM 82599 VF port 1 tx burst -> 82599 VF ->
>Packet generator
>+In this example, the packet flow path is::
>+
>+ Packet generator -> 82599 VF
>+ -> Guest VM 82599 port 0 rx burst
>+ -> Guest VM VMXNET3 port 1 tx burst
>+ -> VMXNET3 device
>+ -> VMware ESXi vSwitch
>+ -> VMXNET3 device
>+ -> Guest VM VMXNET3 port 0 rx burst
>+ -> Guest VM 82599 VF port 1 tx burst
>+ -> 82599 VF
>+ -> Packet generator
>--
>1.8.1.4
>
next prev parent reply other threads:[~2015-04-13 21:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 14:45 John McNamara
2015-04-13 21:11 ` Yong Wang [this message]
2015-04-13 21:23 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D1517A8E.3F09A%yongwang@vmware.com \
--to=yongwang@vmware.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).